Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor crc8_dvb_s2 Function for Improved Readability and Maintainability #175

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MDLZCOOL
Copy link

Description:
This merge request refactors the crc8_dvb_s2 function to enhance code clarity and maintainability. The main changes include:

  • Extracting crc8_dvb_s2 from the MSP class and making it an independent function.
  • Replacing the original bitwise implementation with the GENERIC_CRC8 class, improving code readability and maintainability.
  • Adding the crc.h header file inclusion in msp.cpp.

These modifications help decouple the function from the MSP class and leverage a more structured approach for CRC-8 calculations. Please review and let me know if any further adjustments are needed.

Testing:

  • Verified functionality remains consistent with the previous implementation.
  • Ensured no regression in MSP-related features.

Thanks for your time! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant