Fix local builds unable to flash custom targets #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building firmware from a local repository, the ELRS Configurator looks in that directory for hardware definitions; however, when passing the built firmware to 'binary_configurator.py' it will always set the hardware definition directory (the flag '--dir') to the ELRS Configurator's local data directory. This means that while the build step works, the flash step fails unexpectedly due to the inconsistent hardware definition files.
This change will only affect local builds and only if a hardware directory exists in the local firmware directory. The purpose of the change is to allow custom targets to work with the ELRS Configurator without needing to upstream new targets to the hardware git repository; therefore, this change is only meant for development/advanced users.