Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node timers instead of minetest.after() #6

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

doxygen-spammer
Copy link
Contributor

This reduces the amount of necessary map block updates.

Before this, temporary light sources were removed and readded in every step, which caused a no-op block update everytime. After this, light_beam() just restarts the node timer, so no nodes actually change when you don’t move the light beam.

This can be observed, after pressing F5 twice, in the client_received_packets graph (yellow).

Additionally, this makes the light beam work over the full active_block_range (when you don’t move), because temporary light sources are static then, so the server considers a block update appropriate.

Unfortunately, this doesn’t work with water. I think, the glow nodes are flooded in a way different to e. g. torches, where on_flood() is not executed.


I suggest to sqash-merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant