fix: changes to form save validations for duplicate facilities

[MatiasArriola]

📌 References

• Issue: Closes https://app.clickup.com/t/86954e0tj #86954e0tj
• Issue: Closes https://app.clickup.com/t/8698148rc #8698148rc

📝 Implementation

• Updated SaveFormDataUseCase:
  • Extracted validation to validate method
  • Check for duplication only for current SurveyId
• Added also a condition for PPSHospitalForm, to avoid Hospital duplicates in the same Survey
• Added getParentSurveyId method to Questionnaire.
• While I looked up SURVEY_ID_FACILITY_LEVEL_DATAELEMENT_ID I saw the opportunity to refactor and reuse the new parentPrevalenceSurveyIdList.
• Tried to do the same with patientIdList, but as Ids were different, I kept the same behavior but just left a TODO comment.

📹 Screenshots/Screen capture

2025-02-19.13-29-07.mp4

[ifoche]

Task linked: CU-86954e0tj The check to avoid duplicate facilities should not check facilities in other surveys

[ifoche]

Task linked: CU-8698148rc Avoid duplicate PPS facilities in the same survey

[9sneha-n]

Thanks @MatiasArriola , looks good.

[9sneha-n]

@MatiasArriola maybe we can check with Miquel if all the ids in patientIdList should be disabled. Maybe we have missed out a few and they should ideally overlap?

[MiquelAdell]

@9sneha-n what do you mean by disabled? That the field in a detail is not editable?

[MatiasArriola]

Yes, I think It could be a good idea to handle this refactor in a separate task/PR.
It is related to the list of metadata IDs that disable a question (e.g. survey id, patient id). Recently parentPrevalenceSurveyIdList and patientIdList were introduced as a code improvement to group these Ids. Although unrelated to this PR, I noticed an opportunity to reuse these lists, but it wasn't straightforward for patientIdList. We would need to review the IDs first.
As Sneha mentioned, reviewing this list might reveal some inconsistent behavior.

[9sneha-n]

Noted. We can add this backlog.