Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: new visualization plugin #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MatiasArriola
Copy link

@MatiasArriola MatiasArriola commented Dec 13, 2024

📌 References

📝 Implementation

  • I initially removed all references to the .js plugin, but then realized that event visualizations wouldn't work with its iframe replacement, so I kept both implementations.
  • Now legacy Plugin scripts are loaded only if required
  • Created a separate PluginVisualizationRepository. Each get is performed individually instead of batching all the requests at the repository level.
  • eventCharts and eventReports are unified into eventVisualizations, as per DHIS docs.
  • I have left a placehoder for OrgUnit filtering.

🔥 Testing

  • Use any DHIS 39+ instance with some dashboards loaded to test.
  • Older versions may work, as long as they implement the eventVisualizations endpoint.
  • During testing, I encountered intermittent issues that I still need to investigate and couldn't reproduce again. These may be related to the DHIS instances used.
    • Inside the Map Visualizations, a form appeared instead of the map.
    • iframes stopped reporting installationStatus correctly
    • Timeout errors in the postRobot communication

Keep js plugins as LegacyPlugins
Load Legacy Plugins conditionally
Load Visualizations independently (new repo)
Move eventReport and eventChart to eventVisualization
Check version to use legacy only for dhis < 39
Refactor and small Type changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant