Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logic for step 4 #21

Merged
merged 6 commits into from
Mar 12, 2024
Merged

logic for step 4 #21

merged 6 commits into from
Mar 12, 2024

Conversation

eperedo
Copy link
Contributor

@eperedo eperedo commented Mar 11, 2024

📌 References

📝 Implementation

📹 Screenshots/Screen capture

Running Analysis with all disaggregations selected:

step_4_all_categories.webm

Running Analysis only for Activity Level:

step_4_activity_level.webm

🔥 Notes to the tester

  • docker: docker.eyeseetea.com/hwf/dhis2-data:2.38-widp-hwf-dq
  • This step only works for Module 1.

@eperedo eperedo requested a review from Ramon-Jimenez March 11, 2024 14:45
Copy link
Contributor

@Ramon-Jimenez Ramon-Jimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @eperedo , some things I've noted:

  • Description should read '...threshold x % configured' , it is lacking the % symbol

  • Issues are being ordered weird, not sure how they are ordered within the code but once each issue has an ID, issue should be based on that ID, and it does not
    image

  • Double counts backend seems to be lacking a division by 100 (/100) in the calculation. It shows 100% deviation for some calculations where (1.1+1.2)/1.3 is 1.00, so that's why I think calculation is lacking a /100

  • Missing disaggregates not sure what is doing, I get some issues with this description but I tried having just Male or Female in Sex Disaggregration and it does not raise any issue.

@Ramon-Jimenez Ramon-Jimenez changed the title logic for step 4 logic for step 4 #8693y77mc Mar 12, 2024
@Ramon-Jimenez Ramon-Jimenez changed the title logic for step 4 #8693y77mc logic for step 4 Mar 12, 2024
@ifoche
Copy link
Member

ifoche commented Mar 12, 2024

@Ramon-Jimenez Ramon-Jimenez merged commit 4be6d6b into development Mar 12, 2024
1 check passed
@Ramon-Jimenez Ramon-Jimenez deleted the feat/backend-step4 branch March 12, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants