Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add grey fields and custom form #481

Open
wants to merge 9 commits into
base: feature/disaggregation-step
Choose a base branch
from

Conversation

eperedo
Copy link
Contributor

@eperedo eperedo commented Feb 19, 2025

📌 References

📝 Implementation

  • Add grey fields screen
  • Generate custom form

📹 Screenshots/Screen capture

Project-Configuration-app_greyfields.online-video-cutter.com.mp4

Custom Form

image

🔥 Notes to the tester

#8696ewgtm
#8698186gt

@eperedo eperedo requested a review from MiquelAdell February 19, 2025 03:05
executing yarn test did not produce any errors but running yarn build produed the following:
./dataset-configuration/src/data/entry-form/CustomForm.ts
  311:11  error  `htmlForm` is not a recommended name for `render` returned value. Instead, you should destructure it, or name it using one of: `view`, or `utils`  testing-library/render-result-naming-convention
@MiquelAdell MiquelAdell requested a review from tokland February 20, 2025 12:31
Copy link
Contributor

@MiquelAdell MiquelAdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in gors training and working. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants