Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new invalid network message on ereferals #2306

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

idelcano
Copy link
Contributor

📌 References

🎩 What is the goal?

Add a error message if the user try to login with invalid credentials without network

📝 How is it being implemented?

I check the login network credentials error with the last saved credentials to decide the error network message.

💥 How can it be tested?

Note: remove the android security pattern is required to test this feature.

Use case 1: Login, block the android screen, and disconect from network... unblock. If you put a invalid password you will see a toast: "The credentials are invalid or the credentials are invalid and connexion is not available", else a network error.

💾 Requires DB migration?

  • Nope, we can just merge this branch.
  • Yes, but we need to apply it before merging this branch.
  • Yes, it's already applied.

🎨 UI changes?

  • Nope, the UI remains as beautiful as it was before!
  • Yeap, here you have some screenshots-

@idelcano idelcano requested review from xurxodev and ifoche October 15, 2018 09:47
@xurxodev xurxodev self-assigned this Oct 16, 2018
Copy link
Contributor

@xurxodev xurxodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@idelcano There is duplicate code to verify credentials against last valid credentials as in LoginUseCase. We should fix this issue without to generate duplicate code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants