-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature refactor question entity #2322
Open
idelcano
wants to merge
18
commits into
development
Choose a base branch
from
feature-refactor_question_entity
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect voucher mapper
…cts using metadata container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 References
🎩 What is the goal?
Remove option list from question.
📝 How is it being implemented?
The ereferrals api pull obtains an object with the list of questions and its options within each question.
To convert and save it i used a object called "Metadata" as wrapper of question and question option relation. And I did change the pull of Questions to pull of Metadata (with separated question and options with the question code as hashmap id in the case of the options).
In that process i needed change the order and way to save some data.
I needed replace the Question.hasOptions() method by a OptionLocalDataSource Query
I found (and fix) some bugs with the optionattributes( not correct colour value and not saved in database).
I moved "IMetadataConfigurationDataSource" file from main to ereferrals.
💥 How can it be tested?
Use case 1: Test cnm pull (login on settings, HC, and send a survey), and the load of village question
Use case 2: Test Ereferrals pull. Send a survey.
Use case 2: Run ereferrals tests (remember move to ereferrals staging variant"
Note: in the case of ereferrals i compare the databases too to see if the result is correct with the user 8001.
💾 Requires DB migration?
🎨 UI changes?