Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature refactor question entity #2322

Open
wants to merge 18 commits into
base: development
Choose a base branch
from

Conversation

idelcano
Copy link
Contributor

@idelcano idelcano commented Oct 31, 2018

📌 References

🎩 What is the goal?

Remove option list from question.

📝 How is it being implemented?

The ereferrals api pull obtains an object with the list of questions and its options within each question.

To convert and save it i used a object called "Metadata" as wrapper of question and question option relation. And I did change the pull of Questions to pull of Metadata (with separated question and options with the question code as hashmap id in the case of the options).

In that process i needed change the order and way to save some data.

I needed replace the Question.hasOptions() method by a OptionLocalDataSource Query

I found (and fix) some bugs with the optionattributes( not correct colour value and not saved in database).

I moved "IMetadataConfigurationDataSource" file from main to ereferrals.

💥 How can it be tested?

Use case 1: Test cnm pull (login on settings, HC, and send a survey), and the load of village question
Use case 2: Test Ereferrals pull. Send a survey.
Use case 2: Run ereferrals tests (remember move to ereferrals staging variant"

Note: in the case of ereferrals i compare the databases too to see if the result is correct with the user 8001.

💾 Requires DB migration?

  • Nope, we can just merge this branch.
  • Yes, but we need to apply it before merging this branch.
  • Yes, it's already applied.

🎨 UI changes?

  • Nope, the UI remains as beautiful as it was before!
  • Yeap, here you have some screenshots-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant