fix: max update depth fix

EyeSeeTea · Sep 28, 2024 · 86089fa · 86089fa
1 parent 9a25539
commit 86089fa
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/src/webapp/pages/dashboard/usePerformanceOverview.ts b/src/webapp/pages/dashboard/usePerformanceOverview.ts
@@ -28,21 +28,20 @@ export function usePerformanceOverview(): State {
     const [order, setOrder] = useState<Order>();
 
     useEffect(() => {
-        if (dataPerformanceOverview) {
+        if (dataPerformanceOverview.length && order) {
             setDataPerformanceOverview(
                 (prevDataPerformanceOverview: PerformanceOverviewMetrics[]) => {
                     const newDataPerformanceOverview = _(prevDataPerformanceOverview)
                         .orderBy([
                             [
-                                (dataPerformanceOverviewData: PerformanceOverviewMetrics) => {
-                                    const value =
-                                        dataPerformanceOverviewData[order?.name || "creationDate"];
-                                    return Number.isNaN(Number(value)) ? value : Number(value);
-                                },
-                                order?.direction || "asc",
+                                item =>
+                                    Number.isNaN(Number(item[order.name]))
+                                        ? item[order.name]
+                                        : Number(item[order.name]),
+                                order.direction,
                             ],
                         ])
-                        .value();
+                        .toArray();
 
                     return newDataPerformanceOverview;
                 }