[feature] Integrate d2-logger (coding dojo ----DO NOT MERGE----- ) #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeonwuli
changed the title
…into feat/d2-logger
deeonwuli
changed the title
bhavananarayanan
changed the title
bhavananarayanan
changed the title
…into feat/d2-logger
tokland
reviewed
Oct 30, 2024
| const mapping: Record<OutbreakDataType, TrackedEntityAttributeId> = { | ||
| disease: RTSL_ZEBRA_ALERTS_DISEASE_TEA_ID, | ||
| hazard: RTSL_ZEBRA_ALERTS_EVENT_TYPE_TEA_ID, | ||
| }; |
There was a problem hiding this comment.
As the mapping is static, it can be defined at the root level and the function.
| }[]; | ||
| } & { | ||
| [key in OutbreakDataType]?: string; | ||
| }; |
There was a problem hiding this comment.
We discussed this a little bit on the Dojo, what was the conclusion? I I think this should work:
{
//...
type: OutbreakDataType;
description: string // "description" or other name
//...
}This works if the type only has one of the types, but that's the case, right?
| const mapping: Record<OutbreakDataType, DataSource> = { | ||
| disease: DataSource.RTSL_ZEB_OS_DATA_SOURCE_IBS, | ||
| hazard: DataSource.RTSL_ZEB_OS_DATA_SOURCE_EBS, | ||
| }; |
src/scripts/common.ts
Outdated
| throw new Error("VITE_DHIS2_AUTH must be set in the .env file"); | ||
|
|
||
| const username = process.env.VITE_DHIS2_AUTH.split(":")[0] ?? ""; | ||
| const password = process.env.VITE_DHIS2_AUTH.split(":")[1] ?? ""; |
There was a problem hiding this comment.
Proposal:
const [username, password] = process.env.VITE_DHIS2_AUTH.split(":")
if (!username || !password)move to root of file or to data repository util
tokland
approved these changes
Nov 11, 2024
| import { | ||
| RTSL_ZEBRA_ALERTS_DISEASE_TEA_ID, | ||
| RTSL_ZEBRA_ALERTS_EVENT_TYPE_TEA_ID, | ||
| } from "../consts/DiseaseOutbreakConstants"; |
There was a problem hiding this comment.
No need to change, but to avoid long imports and dispersion of info, values can be grouped in the constants file by some criteria.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 References
📝 Implementation
📹 Screenshots/Screen capture
🔥 Notes to the tester
To test:
yarn script-map-outbreak-to-alertsLogs are saved as events in the RTSL_ZEBRA_MAPPING_LOGGER event program [usU7YBzuhaE].
#8695pt0av