Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Team Builder Program Stage as a Form #25

Merged
merged 11 commits into from
Oct 15, 2024

Conversation

anagperal
Copy link
Contributor

@anagperal anagperal commented Oct 9, 2024

📌 References

📝 Implementation

  • Save in incident management team when create/edit diseaseOutbreak event
  • Save incident manager when change in incident management team builder
  • In Team member assigned and in Reports to… only users in group RTSL_ZEBRA_INCIDENT_MANAGEMENT_TEAM_MEMBERS, but if I choose Incident Manager Role then only users in group RTSL_ZEBRA_INCIDENTMANAGER
  • In reports to only appear members already created in the tree
  • Reports to could be empty to be root in the tree --> any role need any validation like cannot be root and has to report to someone???
  • disabled in reports the value selected in team member because a member cannot report to itself
  • incident manager cannot be deleted, only can be edited so this role does not appear when click on Assing role and delete button is disabled when click in this role
  • Edit profile button in profile modal --> go to edit user in DHIS2
  • Search

📹 Screenshots/Screen capture

image

Screenshot from 2024-10-09 12-00-30
Screenshot from 2024-10-09 12-00-17
Screenshot from 2024-10-09 12-00-14
Screenshot from 2024-10-09 12-00-03
image

🔥 Notes to the tester

fields: dataElementFields,
paging: false,
filter: {
id: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to get the data elements of incident management team builder program stage you can use : https://metadata.eyeseetea.com/rsl-zebra/api/programStages/DwEOpUBGgOp/programStageDataElements
If you do it from the above api, then if new data elements are added to the program stage they will automatically be fetched. I am not sure if that will help in this context, if it does, then you can use it.

return Future.joinObj(
{
dataElementRoles: apiToFuture(
this.api.models.dataElements.get({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this call should be made in RoleD2Repository as it is related to fetching roles. Two different repositories can be called in the use case and then any mapping between them can be done in use case.

Copy link
Contributor

@9sneha-n 9sneha-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes suggested

@anagperal anagperal marked this pull request as draft October 10, 2024 09:40
@anagperal anagperal marked this pull request as ready for review October 10, 2024 12:47
Copy link
Contributor

@9sneha-n 9sneha-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @anagperal

@bhavananarayanan bhavananarayanan merged commit ab15fe6 into development Oct 15, 2024
1 check passed
@bhavananarayanan bhavananarayanan deleted the feature/incident-management-team-builder branch October 15, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants