generated from EyeSeeTea/dhis2-app-skeleton
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Incident action forms #26
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create form summary page, action plan form and response action form
…into feature/incident-action-plan
this also fixes the failing test
anagperal
reviewed
Oct 15, 2024
src/CompositionRoot.ts
Outdated
@@ -62,7 +67,8 @@ function getCompositionRoot(repositories: Repositories) { | |||
getWithOptions: new GetEntityWithOptionsUseCase(repositories), | |||
save: new SaveEntityUseCase( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better to add directly repositories
and in the use case get them like for example in the use case GetDiseaseOutbreakByIdUseCase
…into feature/incident-action-plan
9sneha-n
approved these changes
Oct 22, 2024
anagperal
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @deeonwuli !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 References
📝 Implementation
to do:
📹 Screenshots/Screen capture
Screen.Recording.2024-10-14.at.06.14.39.mov
🔥 Notes to the tester
#8694tp1ju