generated from EyeSeeTea/dhis2-app-skeleton
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<DO NOT MERGE> Coding dojo: refactor to apply aggregate root pattern in DiseaseOutbreakEvent + IncidentManagementTeam #29
Open
anagperal
wants to merge
15
commits into
development
Choose a base branch
from
refactor/disease-outbreak-aggregate-root-im-team
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to DiseaseOutbreakEventD2Repository
…am and move it to diseaseOutbreakEvent
…iseaseOutbreakByIdUseCase and in DeleteIncidentManagementTeamMemberRoleUseCase only use disease outbreak id and Incident Management Team Role Id to delete
anagperal
changed the base branch from
development
to
fix/incident-management-team-fixes
November 7, 2024 18:07
… use DiseaseOutbreakEventAggregateRoot
… use DiseaseOutbreakEventAggregateRoot
Base automatically changed from
fix/incident-management-team-fixes
to
development
November 11, 2024 10:52
…ot to addTeamMemberToIncidentManagementTeamHierarchy
xurxodev
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @anagperal
I approve this PR because it is the beginning of a very big refactor and some things are temporal.
However, I leave here all things I saw:
- In the future, DiseaseOutbreakEventTestRepository only should have: get, getById, save and delete. We should save and return always the aggregate root, and we should not have methods to retrieve only children.
- Great to request roles and team members to start the app using app context but we should not have GetConfigurationsUseCase and GetConfigurationsRepository. roles, teamMembers and incidentManagers are different entities y should have different use cases and repositories, all called to start the app. Configurations entity doesn’t exist.
- I understand that the keyword AgreggateRoot is to identify old code and new code, in the future I would remove this keyword of entities, functions, etc..
- Great to add validations to new aggregate root to addTeamMemberToIncidentManagementTeamHierarchy, in the future we would need add tests for this validations using the aggregate root
- In the future all validations related to aggregate root should be done in the entity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 References
📝 Implementation
IncidentManagementTeamD2Repository
and add functions directly toDiseaseOutbreakEventD2Repository
CompositionRoot
functions related to incidentManagementTeam and move it to diseaseOutbreakEventgetIncidentManagementTeamMember
(in repo and usecase) and get inGetDiseaseOutbreakByIdUseCase
the incident manager using theincidentManagerName
filteringincidentManagementTeam
deleteIncidentManagementTeamMemberRole
andsaveIncidentManagementTeamMemberRole
and have in params only necessary, do not condition the domain to what the repo endpoint needs (remove roles from params and improve code)GetDiseaseOutbreakEventAggregateRootByIdUseCase
,DiseaseOutbreakEventAggregateRoot
andIncidentManagementTeamInAggregateRoot
in order to apply aggregate root pattern in Incident Management Team Builder pageuseIncidentManagementTeamView
fromIncidentManagementTeamInAggregateRoot
+TeamMember[]
+Role[]
= new entity in presentation layerIncidentManagementTeam
as entity and leave it asIncidentManagementTeamInAggregateRoot
.IncidentManagementTeam
will be the entity used in Presentation LayerFuture:
📹 Screenshots/Screen capture
🔥 Notes to the tester