-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes in incident management team builder page #36
Fixes in incident management team builder page #36
Conversation
…cident managers and fix URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anagperal The multi step forms stop working with saving currentEventTracker in local state
username: member.username, | ||
})); | ||
|
||
return entries.reduce((mapAcc, { parentUsername, username }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
const currentEventTracker = getCurrentEventTracker(); | ||
const { existingEventTrackerTypes } = useExistingEventTrackerTypes(); | ||
useCheckWritePermission(formType); | ||
const snackbar = useSnackbar(); | ||
|
||
useEffect(() => { | ||
// NOTICE: This if is to avoid infinite loop when the form page is reloaded from browser | ||
if ( | ||
currentEventTrackerState && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anagperal With this change, multi step forms stop working. For example, risk and IAP are multi step forms. Clicking on next does not go to the next page. PFA video.
risk-multi-step-not-working.mov
iap-multi-step-not-working.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anagperal With this change, multi step forms stop working. For example, risk and IAP are multi step forms. Clicking on next does not go to the next page. PFA video.
risk-multi-step-not-working.mov
iap-multi-step-not-working.mov
Solved! Check if this is correct 368eb3e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anagperal Thank you! this was a miss on my end , definitely need this change.
📌 References
📝 Implementation
📹 Screenshots/Screen capture
Screencast.from.2024-11-07.17-27-51.webm
🔥 Notes to the tester