Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in incident management team builder page #36

Merged
merged 13 commits into from
Nov 11, 2024

Conversation

anagperal
Copy link
Contributor

@anagperal anagperal commented Nov 6, 2024

📌 References

📝 Implementation

  • Unselected item after delete it
  • For the time being, do not allow to delete a parent member in the hierarchy if all children are not also selected, because that member is the one that others have to go to in order to report
  • Allow deletion of team roles in bulk except when parents + not all children selected
  • Fix search: now user can search by name or by role and tree is flatten when some search term. Also show total selected items when searching if any
  • Expand team by default
  • Fix bug multiple incident managers
  • Change disease outbreak event id in page URL
  • Fix infinity loop when you open directly URL without having been on event tracker page before
  • Incident Management Team contacts table
  • Do not allow child be in the team hierarchy with itself as parent

📹 Screenshots/Screen capture

image

Screenshot from 2024-11-07 11-20-25

image
Screenshot from 2024-11-07 14-30-12

Screencast.from.2024-11-07.17-27-51.webm

🔥 Notes to the tester

Base automatically changed from fix/some-more-fixes to fix/local-timezone November 7, 2024 09:58
@anagperal anagperal marked this pull request as ready for review November 7, 2024 10:27
@anagperal anagperal marked this pull request as draft November 7, 2024 10:37
@anagperal anagperal marked this pull request as ready for review November 7, 2024 11:30
@anagperal anagperal requested a review from 9sneha-n November 7, 2024 11:30
Copy link
Contributor

@9sneha-n 9sneha-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anagperal The multi step forms stop working with saving currentEventTracker in local state

username: member.username,
}));

return entries.reduce((mapAcc, { parentUsername, username }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

const currentEventTracker = getCurrentEventTracker();
const { existingEventTrackerTypes } = useExistingEventTrackerTypes();
useCheckWritePermission(formType);
const snackbar = useSnackbar();

useEffect(() => {
// NOTICE: This if is to avoid infinite loop when the form page is reloaded from browser
if (
currentEventTrackerState &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anagperal With this change, multi step forms stop working. For example, risk and IAP are multi step forms. Clicking on next does not go to the next page. PFA video.

risk-multi-step-not-working.mov
iap-multi-step-not-working.mov

Copy link
Contributor Author

@anagperal anagperal Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anagperal With this change, multi step forms stop working. For example, risk and IAP are multi step forms. Clicking on next does not go to the next page. PFA video.

risk-multi-step-not-working.mov
iap-multi-step-not-working.mov

Solved! Check if this is correct 368eb3e

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anagperal Thank you! this was a miss on my end , definitely need this change.

@anagperal anagperal requested a review from 9sneha-n November 11, 2024 07:25
Base automatically changed from fix/local-timezone to development November 11, 2024 10:51
@bhavananarayanan bhavananarayanan merged commit 7421322 into development Nov 11, 2024
1 check passed
@bhavananarayanan bhavananarayanan deleted the fix/incident-management-team-fixes branch November 11, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants