Fix/IAP fixes #37
Merged
Fix/IAP fixes #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autocalculate timeLine value based on the dueDate value
autocalculate timeLine value based on the dueDate value
…into fix/iap-fixes
deeonwuli
requested review from
9sneha-n,
anagperal and
bhavananarayanan
and removed request for
9sneha-n
9sneha-n
reviewed
Nov 8, 2024
| allTeamMembers: this.teamMemberRepository.getAll(), | ||
| incidentResponseOfficers: this.teamMemberRepository.getIncidentResponseOfficers(), | ||
| managers: this.teamMemberRepository.getIncidentManagers(), | ||
| riskAssessors: this.teamMemberRepository.getRiskAssessors(), |
9sneha-n
reviewed
Nov 8, 2024
9sneha-n
reviewed
Nov 8, 2024
There was a problem hiding this comment.
looks good @deeonwuli One query on dataPerformanceOverview. Which scenario is this required? Is it on reload?
9sneha-n
reviewed
Nov 8, 2024
|
|
||
| snackbar.error(summaryError); | ||
| goTo(RouteName.DASHBOARD); |
There was a problem hiding this comment.
the " goTo(RouteName.DASHBOARD);" has been removed. I think it is required no?
yes, exactly that since the |
ah nice one @deeonwuli |
9sneha-n
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 References
📝 Implementation
📹 Screenshots/Screen capture
🔥 Notes to the tester
#8696j3edq