generated from EyeSeeTea/dhis2-app-skeleton
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] risk and iap fixes #39
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
632e126
chore: remove dashboard section title
deeonwuli 53a21c3
fix: show correct options for new response action section
deeonwuli 86e2a7f
fix: cancel iap form
deeonwuli 9a36a87
feat: make verification field read only
deeonwuli f1a8ba4
chore: update .po files
deeonwuli 9ef3aa2
feat: move incident manager user card
deeonwuli a1e6348
feat: add gotoriskgrading button
deeonwuli 85abec6
chore: revert risk assessment button change
deeonwuli 856f1df
refactor: get response action options from configurations
deeonwuli 8880da2
refactor: get incident manager user group in configurations
deeonwuli b4a4107
refactor: get usergroup by code in data repo
deeonwuli 0b2e427
feat: button to add new grade
deeonwuli 23de436
feat: edit single incident response action
deeonwuli 29b39e6
feat: update translation files
deeonwuli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
import { D2Api } from "@eyeseetea/d2-api/2.36"; | ||
import { UserGroupRepository } from "../../domain/repositories/UserGroupRepository"; | ||
import { apiToFuture, FutureData } from "../api-futures"; | ||
import { assertOrError } from "./utils/AssertOrError"; | ||
import { UserGroup } from "../../domain/entities/UserGroup"; | ||
import { RTSL_ZEBRA_INCIDENTMANAGER } from "./TeamMemberD2Repository"; | ||
|
||
export class UserGroupD2Repository implements UserGroupRepository { | ||
constructor(private api: D2Api) {} | ||
|
||
getIncidentManagerUserGroupByCode(): FutureData<UserGroup> { | ||
return apiToFuture( | ||
this.api.metadata.get({ | ||
userGroups: { | ||
fields: { | ||
id: true, | ||
}, | ||
filter: { | ||
code: { eq: RTSL_ZEBRA_INCIDENTMANAGER }, | ||
}, | ||
}, | ||
}) | ||
) | ||
.flatMap(response => | ||
assertOrError(response.userGroups[0], `User group ${RTSL_ZEBRA_INCIDENTMANAGER}`) | ||
) | ||
.map(userGroup => userGroup); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import { Future } from "../../../domain/entities/generic/Future"; | ||
import { UserGroup } from "../../../domain/entities/UserGroup"; | ||
import { UserGroupRepository } from "../../../domain/repositories/UserGroupRepository"; | ||
import { FutureData } from "../../api-futures"; | ||
|
||
export class UserGroupTestRepository implements UserGroupRepository { | ||
getIncidentManagerUserGroupByCode(): FutureData<UserGroup> { | ||
return Future.success({ | ||
id: "1", | ||
}); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is quite confusing, change "incident-response-action" to "single-incident-response-action" .
Make the change in the next PR for v2, so that we are not blocking release for this code review comment.