[feature] Remove added risk summary and response action options #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeonwuli
changed the title
…into feat/remove-added-option
anagperal
reviewed
Nov 28, 2024
9sneha-n
reviewed
Nov 28, 2024
9sneha-n
reviewed
Nov 28, 2024
| @@ -104,6 +111,7 @@ export function useForm(formType: FormType, id?: Id): State { | |||
| isIncidentManager: isIncidentManager, | |||
| }), | |||
| }); | |||
| setEntityData(formData); | |||
There was a problem hiding this comment.
isn't formdata already set in setConfigurableForm ? why not reuse it?
There was a problem hiding this comment.
i'm updating entityData every time a form option is removed so i can get the entityId using the index. when i attempted to do this using formData, i wouldn't get the correct entityId and i would run into an error onPrimaryButtonClick
9sneha-n
approved these changes
Nov 28, 2024
anagperal
reviewed
Nov 28, 2024
anagperal
requested changes
Nov 28, 2024
There was a problem hiding this comment.
thanks @deeonwuli ! Only one important comment: validate also the formState when something is deleted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 References
📝 Implementation
📹 Screenshots/Screen capture
🔥 Notes to the tester
#8696j3edq