Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the serial command manager preventing the boards from connecting to wi-fi #60

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

lorow
Copy link
Collaborator

@lorow lorow commented Feb 26, 2024

Fixes the issues with the tracker boards not connecting to Wi-Fi when powered up without being connected to a serial monitor.

A leftover from the initial implementation was preventing the loop() function from ever returning control once the serial command manager tried to receive a command.

@lorow lorow changed the title Fix the serial command manager preventing the Fix the serial command manager preventing the boards from connecting to wi-fi Feb 26, 2024
@lorow lorow requested a review from ZanzyTHEbar March 6, 2024 19:22
@lorow lorow marked this pull request as ready for review March 6, 2024 19:22
Copy link
Collaborator

@ZanzyTHEbar ZanzyTHEbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Yeah, in embedded NEVER use a while loop - there is never a need for it and it will always lead to a soft-lock issue. Unless you have a multi-threaded cpu, stay away from while loops at all costs.

@lorow lorow force-pushed the fix/serial-command-hanging branch from 408da89 to fe7452f Compare March 11, 2024 16:13
@lorow lorow merged commit 09f0b25 into master Mar 11, 2024
46 checks passed
@lorow lorow deleted the fix/serial-command-hanging branch March 11, 2024 16:26
github-actions bot pushed a commit that referenced this pull request Mar 11, 2024
## [2.4.0](v2.3.0...v2.4.0) (2024-03-11)

### 🍕 Features

* Fix the serial command manager preventing the boards from connecting to wi-fi ([#60](#60)) ([09f0b25](09f0b25))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants