Changed the JoinSession (removed the pin) and added share_plus versio…

…n 7.0.2
F4zination · Apr 24, 2024 · 36a9f52 · 36a9f52
1 parent 76ffa22
commit 36a9f52
Show file tree

Hide file tree

Showing 8 changed files with 23 additions and 18 deletions.
diff --git a/duo_client/android/build.gradle b/duo_client/android/build.gradle
@@ -1,5 +1,5 @@
 buildscript {
-    ext.kotlin_version = '1.7.10'
+    ext.kotlin_version = '1.8.0'
     repositories {
         google()
         mavenCentral()

diff --git a/duo_client/lib/provider/api_provider.dart b/duo_client/lib/provider/api_provider.dart
@@ -49,8 +49,8 @@ class ApiProvider extends ChangeNotifier implements AbstractServerConnection {
   }
 
   @override
-  Future<int> joinSession(String token, int sessionId, String pin) {
-    return _serverConnection!.joinSession(token, sessionId, pin);
+  Future<int> joinSession(String token, int sessionId) {
+    return _serverConnection!.joinSession(token, sessionId);
   }
 
   @override

diff --git a/duo_client/lib/utils/connection/abstract_connection.dart b/duo_client/lib/utils/connection/abstract_connection.dart
@@ -3,6 +3,6 @@ abstract class AbstractServerConnection {
   Future<int> registerUser(String username);
   Future<int> loginUser(String uuid);
   Future<int> createSession(String token, String pin);
-  Future<int> joinSession(String token, int sessionId, String pin);
+  Future<int> joinSession(String token, int sessionId);
   Future<int> disconnectSession(String token, int sessionId);
 }
diff --git a/duo_client/lib/utils/connection/grpc_server_connection.dart b/duo_client/lib/utils/connection/grpc_server_connection.dart
@@ -124,13 +124,12 @@ class GrpcServerConnection extends AbstractServerConnection {
   }
 
   @override
-  Future<int> joinSession(String token, int sessionId, String pin) async {
+  Future<int> joinSession(String token, int sessionId) async {
     try {
       ResponseStream<SessionStream> stream =
           client.joinSession(JoinSessionRequest()
             ..token = token
-            ..sessionId = sessionId
-            ..pin = pin);
+            ..sessionId = sessionId);
 
       await for (SessionStream ss in stream) {
         print('Received: ${ss.sessionState.users.length}');

diff --git a/duo_client/lib/widgets/join_dialog.dart b/duo_client/lib/widgets/join_dialog.dart
@@ -9,14 +9,14 @@ import 'package:flutter_riverpod/flutter_riverpod.dart';
 import 'package:flutter_svg/flutter_svg.dart';
 
 class JoinDialog extends ConsumerStatefulWidget {
-  const JoinDialog({Key? key});
+  const JoinDialog({super.key});
 
   @override
   ConsumerState<JoinDialog> createState() => _JoinDialogState();
 }
 
 class _JoinDialogState extends ConsumerState<JoinDialog> {
-  TextEditingController _controller = TextEditingController();
+  final TextEditingController _controller = TextEditingController();
   bool wrongInviteCode = false;
   String hintText = 'Enter the invite code to join a game';
 
@@ -76,12 +76,19 @@ class _JoinDialogState extends ConsumerState<JoinDialog> {
                       ))),
               IconButton(
                 onPressed: () async {
-                  print('Joining session with invite code ${_controller.text}');
+                  if (_controller.text.isEmpty || _controller.text.length < 6) {
+                    setState(() {
+                      wrongInviteCode = true;
+                      hintText = 'Invite code needs to be 6 digits long';
+                    });
+                    return;
+                  }
                   int stauts = await ref.read(apiProvider).joinSession(
                       ref.read(storageProvider).accessToken,
-                      5,
-                      _controller.text);
+                      int.parse(_controller.text));
                   if (stauts == 0) {
+                    print(
+                        'Joining session with invite code ${_controller.text}');
                     Navigator.of(context)
                         .pushReplacementNamed(LobbyScreen.route);
                   } else {

diff --git a/duo_client/pubspec.lock b/duo_client/pubspec.lock
@@ -700,18 +700,18 @@ packages:
     dependency: "direct main"
     description:
       name: share_plus
-      sha256: ef3489a969683c4f3d0239010cc8b7a2a46543a8d139e111c06c558875083544
+      sha256: ed3fcea4f789ed95913328e629c0c53e69e80e08b6c24542f1b3576046c614e8
       url: "https://pub.dev"
     source: hosted
-    version: "9.0.0"
+    version: "7.0.2"
   share_plus_platform_interface:
     dependency: transitive
     description:
       name: share_plus_platform_interface
-      sha256: "0f9e4418835d1b2c3ae78fdb918251959106cefdbc4dd43526e182f80e82f6d4"
+      sha256: "251eb156a8b5fa9ce033747d73535bf53911071f8d3b6f4f0b578505ce0d4496"
       url: "https://pub.dev"
     source: hosted
-    version: "4.0.0"
+    version: "3.4.0"
   shelf:
     dependency: transitive
     description:

diff --git a/duo_client/pubspec.yaml b/duo_client/pubspec.yaml
@@ -48,7 +48,7 @@ dependencies:
   animated_background: ^2.0.0
   flutter_spinkit: ^5.2.1
   qr_flutter: ^4.1.0
-  share_plus: ^9.0.0
+  share_plus: 7.0.2
 
 
 dev_dependencies:

diff --git a/proto/session_messages.proto b/proto/session_messages.proto
@@ -29,7 +29,6 @@ message CreateSessionResponse{
 message JoinSessionRequest{
     string token = 1;
     int32 session_id = 2;
-    string pin = 3;
 }
 
 message SessionStream{