Skip to content

Commit

Permalink
fixed bugs
Browse files Browse the repository at this point in the history
  • Loading branch information
oriventi committed Jun 4, 2024
1 parent 75dcf64 commit 97b4453
Show file tree
Hide file tree
Showing 7 changed files with 25 additions and 18 deletions.
7 changes: 4 additions & 3 deletions duo_backend/api/friend_routes.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,12 @@ func (server *Server) SendFriendRequest(context context.Context, req *pb.FriendR
}

_, dbErr := server.Store.AddFriendRequest(context, db.AddFriendRequestParams{
RequesterID: payload.UserID,
RequesteeID: targetUuid,
RequesterID: payload.UserID,
RequesterName: payload.Username,
RequesteeID: targetUuid,
})

if dbErr != nil {
if dbErr != nil && dbErr != sql.ErrNoRows {
log.Printf("error adding friend request: %v", dbErr)
return nil, status.Errorf(codes.Internal, "error adding friend request to db")
}
Expand Down
2 changes: 1 addition & 1 deletion duo_client/lib/provider/api_provider.dart
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ class ApiProvider extends ChangeNotifier implements AbstractServerConnection {
}
case StackStateEvent:
{
debugPrint('Received Stack State Event');
final stackStateEvent = event as StackStateEvent;
_stackState = stackStateEvent.state;
notifyListeners();
Expand Down Expand Up @@ -342,7 +343,6 @@ class ApiProvider extends ChangeNotifier implements AbstractServerConnection {
"Event stream should not be accessed from apiProvider");

@override
// TODO: implement eventController
StreamController<ServerEvent> get eventController => throw UnimplementedError(
"Event controller should not be accessed from apiProvider");
}
Expand Down
15 changes: 8 additions & 7 deletions duo_client/lib/screens/lobby_screen.dart
Original file line number Diff line number Diff line change
Expand Up @@ -48,19 +48,20 @@ class _LobbyScreenState extends ConsumerState<LobbyScreen>
setState(() {
joiningGame = true;
debugPrint('Game Id: ${_apiProvider.gameId}');
WidgetsBinding.instance.addPostFrameCallback((_) {
Navigator.of(context).pushReplacementNamed(GameScreen.route);
});
});
WidgetsBinding.instance.addPostFrameCallback((_) {
Navigator.of(context).pushReplacementNamed(GameScreen.route);
});
}
if (_apiProvider.gameId == -2 && !_apiProvider.hasLobbyStream) {
setState(() {
debugPrint('Lobby Stream: ${_apiProvider.lobbyStatus?.lobbyId}');
//Case if lobby is deleted by the Host
WidgetsBinding.instance.addPostFrameCallback((_) {
debugPrint('Lobby deletion detected; leaving... ');
Navigator.of(context).pushReplacementNamed(HomeScreen.route);
});

debugPrint('Lobby deletion detected; leaving... ');
});
WidgetsBinding.instance.addPostFrameCallback((_) {
Navigator.of(context).pushReplacementNamed(HomeScreen.route);
});
}

Expand Down
2 changes: 2 additions & 0 deletions duo_client/lib/utils/connection/grpc_server_connection.dart
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,7 @@ class GrpcServerConnection extends AbstractServerConnection {
streamEstablishedCompleter.complete();
}
eventController.add(StackStateEvent(value));
debugPrint('card on top: ${value.placeStack.cardIdOnTop}');
debugPrint('stack stream acknowledge received');
}
},
Expand Down Expand Up @@ -382,6 +383,7 @@ class GrpcServerConnection extends AbstractServerConnection {

gameStream?.listen(
(value) {
debugPrint('new game state: $value');
eventController.add(GameStateEvent(value));
},
cancelOnError: true,
Expand Down
2 changes: 1 addition & 1 deletion duo_client/lib/widgets/card_scroll_view.dart
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ class _CardScrollViewState extends ConsumerState<CardScrollView> {
itemCount: cards.length,
itemBuilder: (context, index) {
return Dismissible(
key: Key(cards[index].cardName),
key: UniqueKey(),
direction: isTurn ? DismissDirection.up : DismissDirection.none,
onDismissed: (direction) {
if (!_isReordering) {
Expand Down
12 changes: 7 additions & 5 deletions duo_client/lib/widgets/game_stacks.dart
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,7 @@ class _GameStacksState extends ConsumerState<GameStacks> {
WidgetsBinding.instance.addPostFrameCallback((_) async {
//init the stack stream
String token = await ref.read(apiProvider).getToken();
await ref
.read(apiProvider)
.getStackStream(token, ref.read(apiProvider).gameId);
ref.read(apiProvider).getStackStream(token, ref.read(apiProvider).gameId);
});
super.initState();
}
Expand All @@ -30,8 +28,12 @@ class _GameStacksState extends ConsumerState<GameStacks> {
ApiProvider _apiProvider = ref.watch(apiProvider);
StackState stackState = _apiProvider.stackState ??
StackState(
drawStack: DrawStackState(cardIds: ['green_3']),
placeStack: PlaceStackState(cardIdOnTop: 'green_4'),
drawStack: DrawStackState(
cardIds:
_apiProvider.stackState?.drawStack.cardIds ?? ['green_1']),
placeStack: PlaceStackState(
cardIdOnTop:
_apiProvider.stackState?.placeStack.cardIdOnTop ?? 'green_1'),
);
return Padding(
padding: const EdgeInsets.all(8.0),
Expand Down
3 changes: 2 additions & 1 deletion duo_client/lib/widgets/invite_dialog.dart
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@ class InviteDialog extends ConsumerWidget {
await Share.share(
'Join me on Duo using this code: *$invideCode*');
},
)
),
// const SizedBox(width: Constants.defaultPadding / 2),
],
),
),
Expand Down

0 comments on commit 97b4453

Please sign in to comment.