Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this is my input #28

Open
Fweddi opened this issue Apr 12, 2019 · 0 comments
Open

this is my input #28

Fweddi opened this issue Apr 12, 2019 · 0 comments

Comments

@Fweddi
Copy link

Fweddi commented Apr 12, 2019

Lines 22 and following in your script file:

            const inputAction = document.createElement('td');
            inputAction.textContent = input.action_point;
            inputRow.appendChild(inputAction);
        } else
        {
            const inputName = document.createElement('td');
            inputName.textContent = input.name;
            const inputOpinion = document.createElement('td');
            inputOpinion.textContent = input.opinion;
            inputRow.appendChild(inputName);
            inputRow.appendChild(inputOpinion);
        }

I feel this could be slightly more clear - you could make explicit the fact that the else block is implicitly testing for an opinion table. Also I was slightly confused with the input prefix with your action table items, such as inputAction and inputRow - are these related to inputs on the page?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant