Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header "front-end" #18

Merged
merged 5 commits into from
Jul 31, 2018
Merged

Header "front-end" #18

merged 5 commits into from
Jul 31, 2018

Conversation

ashatat
Copy link
Contributor

@ashatat ashatat commented Jul 29, 2018

Related to #9

Summary

  • create the front-end for the Header component which contains:
    • HeaderTitle (if we pass title in the props then it will show the {props.title} value as a Header otherwise it'll display the App logo (CAS) )
    • Notifications (if we pass connectReq then it will check if it contains connection requests as objects contain the details then it'll show details, otherwise show "You don't have notifications")

ahmadmshatat
ahmadmshatat reviewed Jul 29, 2018
View reviewed changes
frontend/src/components/Header/HeaderTitle/HeaderTitle.js Outdated

import ('../style.css');

class Title extends Component {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think u didn't need use class here, u can use stateless function

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahmadmshatat I edited it
please review it again

@ashatat ashatat requested review from emanKhaledh and ishak52 July 29, 2018 10:02
@yahyaHB yahyaHB merged commit 4b73ab1 into master Jul 31, 2018
@emanKhaledh emanKhaledh deleted the header branch July 31, 2018 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmadmshatat ahmadmshatat ahmadmshatat approved these changes

@emanKhaledh emanKhaledh Awaiting requested review from emanKhaledh

@ishak52 ishak52 Awaiting requested review from ishak52

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashatat @ahmadmshatat @yahyaHB