Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: header front-end refactor code #27

Merged
merged 2 commits into from
Aug 2, 2018
Merged

fix: header front-end refactor code #27

merged 2 commits into from
Aug 2, 2018

Conversation

ashatat
Copy link
Contributor

@ashatat ashatat commented Aug 1, 2018

Related to #9

Summary

  • refactor the code:
    • add connectReq to the state of the component itself instead of importing it from the app component
    • solve the notification number style

@@ -6,7 +6,9 @@
background-color: #FC2E2E;
color: #fff;
text-align: center;
font-size: 19px;
padding: auto;
line-height: 20px; /*to center it vertically*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please delete unnecessary comments!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted them

@yahyaHB yahyaHB merged commit b99169d into master Aug 2, 2018
@emanKhaledh emanKhaledh deleted the header branch August 5, 2018 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants