Update events function #39
Conversation
…rror middlewares, and added route testing for the 404 display page and the home display page.
src/controllers/update_events.js
Outdated
| const dbConnection = require('../database/db_connect'); | ||
|
|
||
| exports.post = (req, res, next) => { | ||
| Events.findByIdAndUpdate(req.params.id, |
There was a problem hiding this comment.
Split file to src/controllers and src/database/queries;
| <section> | ||
| <div class="headline"> | ||
| <h3>Welcome to the GazaSkyGeeks Narrowcast</h3> | ||
| <button type="button" id="#narrow-button" class="narrow-button">See narrowcast</button> |
There was a problem hiding this comment.
Don't use # in an id selector.
| </div> | ||
|
|
||
| <div class="programs-container"> | ||
| <button type="button" id="view-programs" class="button" name="view programs">Programs</button> |
There was a problem hiding this comment.
use less ids and more classs.
src/views/update_events.hbs
Outdated
| @@ -0,0 +1,53 @@ | |||
| <h1>add events here</h1> | |||
| <form class="" method="post"> | |||
| <div class=""> | |||
src/views/update_events.hbs
Outdated
| <button type="submit" name="button" id="add-events">add events</button> | ||
| </form> | ||
|
|
||
| <p class="ss" id="ss"> |
There was a problem hiding this comment.
Use less ids and more classs.
| .expect('content-type', 'text/html; charset=utf-8') | ||
| .end((err, res) => { | ||
| if (err) t.error(err); | ||
| t.equal(res.text.includes('Page Not Found'), true, 'error should inform the user that the page is not found'); |
There was a problem hiding this comment.
You don't have to test HTML, just having a response of 404 is enough to say that this test does what it should.
test/controllers/home.js
Outdated
| .expect('x-powered-by', 'Express') | ||
| .end((err, res) => { | ||
| t.error(err); | ||
| t.equal(Object.values(res.headers).indexOf('Express') > -1, true, 'headers should include the express technology'); |
There was a problem hiding this comment.
So you already said .expect('x-powered-by', 'Express') but then you make another equal to check that the headers actually contain Express? What's so important about 'x-powered-by', 'Express' That you want to make sure its there so bad?
test/controllers/update_events.js
Outdated
| .expect(200) | ||
| .end((err, res) => { | ||
| if (err) return t.error(err); | ||
| t.equal(JSON.stringify(res).includes('</form>'), true, 'render response should include a form element'); |
There was a problem hiding this comment.
Again, you don't have to validate HTML.
test/controllers/update_events.js
Outdated
| .expect(200) | ||
| .end((err, response) => { | ||
| if (err) t.end(err); | ||
| t.equal(JSON.stringify(response).includes('new people'), true, '2nd coding for everyone should be updated to the new event with new people as speakers'); |
There was a problem hiding this comment.
Man I spent 4 hours trying to access the supertest response object down to the key that holds the information I want and couldn't. I don't know how to test for it the way I want to.
test/tests_index.js
Outdated
| .then(() => { | ||
| // testing the update event controller | ||
| require('./controllers/update_events'); | ||
| }); |
There was a problem hiding this comment.
What if an error happened somewhere above? What would catch it?
…ler and usable anywhere, with proper validation in the backend, no frontend validation yet
…ultiple events per day
| @@ -0,0 +1,2 @@ | |||
| PORT = 3000 | |||
There was a problem hiding this comment.
Do not push the config.env
| viewEvents.addEventListener('click', () => { | ||
| fetch('/events') | ||
| .then(() => { | ||
| window.location = '/events'; |
There was a problem hiding this comment.
You could've made it just an href, why make an eventListener?
| @@ -0,0 +1,32 @@ | |||
| const query = require('../database/queries/update_events_query'); | |||
There was a problem hiding this comment.
Name your query something more readable. Like, what is it responsible for? and then ask yourself, what does this query do? What is it's input and what's the output? Your name should be very specific, and your input should be very relevant, convince me why is your query taking { params: req.params, body: req.body } not just { id }.
| @@ -0,0 +1,30 @@ | |||
| const Events = require('../event_schema'); | |||
|
|
|||
| const query = (req, callback) => { | |||
There was a problem hiding this comment.
And what does this query do exactly? Can't I understand it's purpose from the name? And what is the req it's taking as input?
| if (err) return err; | ||
| callback(); | ||
| }) | ||
| .then(() => { |
No description provided.