-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/3240 mark watched replay with indicator #3293
base: develop
Are you sure you want to change the base?
Feature/3240 mark watched replay with indicator #3293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main things I see right now are just that the watched label seems a little in the wrong place.
Currently it is shown like all the other meta information about the replay but it is more information about the users action so maybe a different display like an overlay on the card or something might be better to be clearer.
Additionally just not sure how much value the date watched adds but that is minor.
I'm also not convinced that the date you watched it is at all relevant. For the visuals: How about making the whole card a slightly darker shade? Giving it a brighter border goes in the right direction, but I think it makes sense to make watched replays less pronounced instead of more pronounced. Replays you have not yet watched are probably more interesting. |
Well, basic user it may be pointless(that's why even time is not shown), but maybe for replay casters would be helpful(Could imagine, that they want to find replay again and they know approximated dated, when they watched...)? Do we have any contact to any? Can we get their response? TBFH, My main motivation is that replay caster would do more casts :D.
@BlackYps What about icon? Do we want go with it? And where?
You want to move it under current specs? What about adding next to replay name? Or right next to Title at the end as separate column? Just pure icon? |
If you want to make life easier for casters then I strongly recommend that you first message some casters and get an understanding of what they need. You can find them if you look for people with the caster role on our discord. If you want to use an icon I would suggest that you also add a tooltip that explains the icon. We have too many icons already where you have to guess what exactly it is supposed to represent, because there is no info other than the icon itself. But I am not sure if we need an icon here at all if we go the way of making the whole card a darker shade. On the other side I am not strongly against an icon. I just care about the feature being coherent and helpful. |
A completed PR should solve/close #3240 - 3240 .
As of now this is sort of PoC(not ready to me merged), if I'm on the right track, what remains is:
this is current state represented in gui:
@Sheikah45 thoughts?