Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to show user defined templates instead of default onland/onwater templates #5586

Merged
merged 6 commits into from
Jun 26, 2024

Conversation

gordenwunderlich
Copy link
Contributor

This adds an option to replace the on land / on water triggering templates with the users ingame templates.
The default templates for empty terrain are very basic (pd with walls, single aa, single torp launcher) and people often have some templates setup themselves that they still want to use preventing them from fully switching to the context based template system without first transferring their templates to the new format.
With this option (defaults to off) your own templates show whenever no other templates match (ignoring templates that match on empty terrain)
image

…nwater templates

Option for an easier transition from regular templates to context based
@Garanas Garanas added the feature: context-based templates related to context-based templates functionality label Oct 28, 2023
@Garanas Garanas added this to the Development iteration IV milestone Oct 28, 2023
@Garanas
Copy link
Member

Garanas commented Oct 28, 2023

We'll include this with a hotfix. I'm wondering whether we should just default this to enabled

@gordenwunderlich
Copy link
Contributor Author

I defaulted to disabled to not break the currently running implementation for people using the feature, but nobody I talked to about the templates was using the water/land templates and only used the context triggering ones.

Also I also don't think the distinction between water and land templates is worth the additional effort of not being able to use the ingame tools to make the template.

If you have some good ideas for such templates then keeping it the way it is would be preferable I think.
If the templates are more like placeholders and you expect people to set up their own land/water templates, then I think defaulting to using the regular templates would be good.

@Garanas Garanas changed the base branch from deploy/fafdevelop to develop June 1, 2024 19:36
@MrRowey MrRowey requested a review from Garanas June 18, 2024 20:45
@MrRowey
Copy link
Member

MrRowey commented Jun 19, 2024

@gordenwunderlich Could you please update this PR with the Conflicx being fixed :)

@MrRowey MrRowey marked this pull request as draft June 19, 2024 10:20
@MrRowey MrRowey requested a review from lL1l1 June 20, 2024 08:20
@MrRowey MrRowey removed this from the Development iteration II of 2024 milestone Jun 20, 2024
@gordenwunderlich
Copy link
Contributor Author

@MrRowey Updated with the develop branch and I added an option to use both context base land/water templates and ingame created templates, for people that already made some templates using the new system or if people want to combine their ingame templates with special on water templates

@MrRowey
Copy link
Member

MrRowey commented Jun 22, 2024

Can you provide me with a small description of the change overall so it can be added to the changlog

@gordenwunderlich
Copy link
Contributor Author

Something like:
Add option to use regular templates with the context based template hotkey.
image
You can choose between simply replacing the default land/water templates or merging them with your own templates

@MrRowey MrRowey marked this pull request as ready for review June 26, 2024 09:28
@MrRowey MrRowey merged commit ee3510f into FAForever:develop Jun 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: context-based templates related to context-based templates functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants