Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Traditional Chinese Translations #6612

Merged
merged 24 commits into from
Jan 14, 2025
Merged

Conversation

Yuchenjimmy
Copy link
Contributor

Update/add translations for several units and tips.

Update/add translations for several units and tips.
Didn't notice there was a debuff, now it's up to date.
@Yuchenjimmy
Copy link
Contributor Author

Yuchenjimmy commented Jan 6, 2025

Also, I used to test translation file in C:\ProgramData\FAForever\DevData\loc\TW\strings_db.lua, then lauch game with cmd C:\ProgramData\FAForever\bin\ForgedAlliance.exe /init init_fafdevelop.lua. But now it seems updated string won't applied now. May I ask how to apply them now? Thank you very much.

@lL1l1
Copy link
Contributor

lL1l1 commented Jan 6, 2025

Also, I used to test translation file in C:\ProgramData\FAForever\DevData\loc\TW\strings_db.lua, then lauch game with cmd C:\ProgramData\FAForever\bin\ForgedAlliance.exe /init init_fafdevelop.lua. But now it seems updated string won't applied now. May I ask how to apply them now? Thank you very much.

The path was changed changed from \DevData\ to \Debug\ in #6366 init_fafdevelop.lua Diff

Removed strings for sorian ai, which was removed by commit c6bba35 accordingly.
@Yuchenjimmy
Copy link
Contributor Author

Thank you!

@Yuchenjimmy Yuchenjimmy marked this pull request as draft January 7, 2025 06:25
@Yuchenjimmy Yuchenjimmy marked this pull request as ready for review January 8, 2025 06:58
@Yuchenjimmy
Copy link
Contributor Author

Hello, would you please review this pull request and merge it? I will creat a new pull request for next update.

Copy link
Contributor

@lL1l1 lL1l1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know Chinese, but I went over it briefly. There was only 1 small mistake.

loc/TW/strings_db.lua Outdated Show resolved Hide resolved
@lL1l1
Copy link
Contributor

lL1l1 commented Jan 10, 2025

Sorry, I forgot, can you add a changelog snippet?

@Yuchenjimmy
Copy link
Contributor Author

Sorry, I forgot, can you add a changelog snippet?

Excuse me, where should I add?

@Yuchenjimmy
Copy link
Contributor Author

Yuchenjimmy commented Jan 10, 2025

lua/ui/dialogs/createunit.lua

Fix syntex error for Toggle Economy tooltip in spawn filter.

<LOC spawn_filter_build_eco>_tipToggle Economy units=><LOC spawn_filter_build_eco_tip>Toggle Economy units

Add LOC entries for following options:

<LOC spawn_filter_count>Count
<LOC spawn_filter_veterancy>Veterancy
<LOC spawn_filter_rotation>Rotation
<LOC spawn_filter_count>Count
<LOC spawn_filter_rotation>Rotation
<LOC spawn_filter_scatter>Scatter
<LOC spawn_filter_preset>Filter Preset
<LOC spawn_filter_save>Save
<LOC spawn_filter_save_tip>Save current filter as preset
<LOC spawn_filter_delete>Delete
<LOC spawn_filter_delete_tip>Delete current filter preset
<LOC spawn_filter_clear>Clear All
<LOC spawn_filter_clear_tip>Clear all filters

lua/ui/lobby/changelog.lua

Add LOC entries for following options:

<LOC uilobby_0004>Github
<LOC uilobby_0005>Patchnotes
<LOC uilobby_0006>Report a bug

lua/ui/lobby/lobby.lua

Add LOC entries for following options:

<LOC lobui_0447>Snowflakes count

lua/ui/lobby/lobbyOptions.lua

Add LOC entries for following options:

<LOC lobui_0808>Disconnection delay
<LOC lobui_0809>Sets the disconnect delay when a player has trouble connecting.
<LOC lobui_0810>Tournament
<LOC lobui_0811>The eject delay is set to 10 seconds and after 90 seconds the player is ejected automatically.
<LOC lobui_0812>Quick
<LOC lobui_0813>The eject delay is set to 30 seconds and after 90 seconds the player is ejected automatically.
<LOC lobui_0814>Regular
<LOC lobui_0815>The eject delay is set to 90 seconds and after 180 seconds the player is ejected automatically.

@lL1l1
Copy link
Contributor

lL1l1 commented Jan 12, 2025

The changelog snippet for your PR would be in /changelog/snippets/other.6612.md; the details for snippets are here: https://faforever.github.io/fa/development/changelog

@Yuchenjimmy
Copy link
Contributor Author

Yuchenjimmy commented Jan 12, 2025

The changelog snippet for your PR would be in /changelog/snippets/other.6612.md; the details for snippets are here: https://faforever.github.io/fa/development/changelog

Finished, am I doing right?

Copy link
Contributor

@lL1l1 lL1l1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty of formatting the snippet and improving the English a bit. Does it look good?

@Yuchenjimmy
Copy link
Contributor Author

Yeah, it looks very well!

@lL1l1 lL1l1 merged commit 3a4294d into FAForever:develop Jan 14, 2025
5 checks passed
@Yuchenjimmy Yuchenjimmy deleted the patch-4 branch January 19, 2025 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants