Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate sync of enhancements #6626

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

lL1l1
Copy link
Contributor

@lL1l1 lL1l1 commented Jan 16, 2025

Description of the proposed changes

Annotate the data about how enhancements are synced.

Testing done on the proposed changes

  • Logging the enhancement queue functions
  • Looking for warnings related to the annotations.

Additional context

  • The EnhQueueData class is declared in construction.lua as it is difficult to find how it gets put into the common enhancement table otherwise.
  • Giving the Sync table a class brings up new undefined field warnings to solve for other sync features in the future

Checklist

  • Changes are annotated, including comments where useful
  • Changes are documented in the changelog for the next game version

@lL1l1 lL1l1 added area: sim Area that is affected by the Simulation of the Game area: ui Anything to do with the User Interface of the Game type: intellisense labels Jan 16, 2025
@lL1l1 lL1l1 marked this pull request as ready for review January 16, 2025 10:04
@lL1l1 lL1l1 added this to the Development Iteration I of 2025 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: sim Area that is affected by the Simulation of the Game area: ui Anything to do with the User Interface of the Game type: intellisense
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant