Add password reset #371
Open
Add password reset #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brutus5000
force-pushed
the
feature/password-reset
branch
7 times, most recently
from
bcb8e6f to
ea0113b
Compare
Sheikah45
reviewed
Jan 2, 2025
src/main/kotlin/com/faforever/userservice/ui/view/recovery/RecoverAccountView.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/faforever/userservice/ui/view/recovery/RecoverAccountView.kt
Outdated
Show resolved
Hide resolved
Comment on lines
+105
to
+110
| val (recoveryType, user) = try { | ||
| recoveryService.parseRecoveryHttpRequest(parameters) | ||
| } catch (e: Exception) { | ||
| showDialog("recovery.setPassword.failed.title", "recovery.setPassword.invalidToken") | ||
| return | ||
| } |
There was a problem hiding this comment.
Kind of surprised we are using exceptions for control flow here when we could just return a sealed class
There was a problem hiding this comment.
Lol also if you want could whip something up that turns the query parameters into a full class, have done it before.
src/main/kotlin/com/faforever/userservice/ui/view/recovery/RecoverViaSteamView.kt
Outdated
Show resolved
Hide resolved
Brutus5000
force-pushed
the
feature/password-reset
branch
from
ea0113b to
c08ba30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.