-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated loss and eval metrics #896
Conversation
merging in main
Codecov ReportAttention: Patch coverage is
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @wood-b ! Just left minor comments.
I double checked training with this, and it looks as expected, energy is slightly better but likely from the stress now being weighted slightly different.
|
||
|
||
class DDPLoss(nn.Module): | ||
""" | ||
This class is a wrapper around a loss function that does a few things |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding this comment, very helpful
This PR built off of #821
Loss Updates:
P2NormLossL2NormLoss. l2mae is still part of registry for backwards compatibility with configs.Evaluator Updates:
Tests:
Energy, forces, and loss all look comparable between eqv2-main (current main) and eqv2-new-loss-test (this PR) trained for 3 epochs on OC20 2M