Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/search #44

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Feature/search #44

wants to merge 5 commits into from

Conversation

bruvio
Copy link
Collaborator

@bruvio bruvio commented Feb 28, 2022

updated search function using handle as input

@bruvio bruvio added the enhancement New feature or request label Feb 28, 2022
data_pipeline_api/pipeline.py Outdated Show resolved Hide resolved
data_pipeline_api/pipeline.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #44 (14c8012) into dev (9fb64a9) will increase coverage by 0.72%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #44      +/-   ##
==========================================
+ Coverage   82.42%   83.15%   +0.72%     
==========================================
  Files           6        6              
  Lines         535      558      +23     
==========================================
+ Hits          441      464      +23     
  Misses         94       94              
Impacted Files Coverage Δ
data_pipeline_api/__init__.py 100.00% <100.00%> (ø)
data_pipeline_api/pipeline.py 92.67% <100.00%> (+1.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fb64a9...14c8012. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
17.4% 17.4% Duplication

@RyanJField
Copy link
Collaborator

Further to the meeting today, The wild card search should search the config data products when using wild cards (*) in the read and write blocks: https://www.fairdatapipeline.org/docs/interface/fdp/#fair-run

@bruvio
Copy link
Collaborator Author

bruvio commented Mar 30, 2022

@bobturneruk @richardreeve @RyanJField the issue regarding the wildcard search has been somehow removed. is it no longer needed? if so, what about this implementation/branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants