Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXmpes arpes import #1

Merged
merged 10 commits into from
Apr 4, 2024
Merged

NXmpes arpes import #1

merged 10 commits into from
Apr 4, 2024

Conversation

rettigl
Copy link
Collaborator

@rettigl rettigl commented Nov 28, 2023

Required changes to make the nexus loader for pyarpes work with NXmpes_arpes subdefinition files and to allow conversion into momentum space

@domna
Copy link
Collaborator

domna commented Nov 29, 2023

Do you have an example file you can provide for testing this? If possible we could also add a test for loading the file here.

@rettigl
Copy link
Collaborator Author

rettigl commented Dec 7, 2023

Do you have an example file you can provide for testing this? If possible we could also add a test for loading the file here.

There is an example notebook now in https://github.com/FAIRmat-NFDI/pynxtools/tree/dev_nxmpes_arpes/examples/mpes
I still need to upload the corresponding data file somewhere.

@domna
Copy link
Collaborator

domna commented Apr 4, 2024

I did some additional checks and simplification and ruff formatted the nexus endstation. This is good to go now form my side @rettigl. Testing and linting will then be fixed in #2.

Copy link
Collaborator Author

@rettigl rettigl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's add further checks etc. in other PRs.
(I cannot approve as I started this PR)

@rettigl rettigl merged commit 6e967fc into master Apr 4, 2024
0 of 3 checks passed
@rettigl rettigl deleted the NXmpes_arpes_import branch April 4, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants