Changes on naming and small improvements #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing my for new everywhere Deleting nomad- prelabel everywhere
Name changes
|
@lauri-codes do you mind checking on this? Ahmed is on holidays and I need this for the Hackathon (I can also fix the documentation regarding plugins) |
lauri-codes
reviewed
Aug 26, 2024
{{cookiecutter.plugin_name}}/py_sources/src/schemas/__init__.py
Outdated
Show resolved
Hide resolved
Change newapp for app_entry_point Fix typo readme
Ok, done. I changed back to |
|
@lauri-codes , you want to give another look or can I merge? I tested it, and all works: https://github.com/JosePizarro3/example-plugin/tree/pyscf-new-template |
|
@JosePizarro3: Looks good, go ahead and merge |
|
Ah, I cannot merge. I don't have write access. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26 and #28
@blueraft can you give it a look? Ideally, this should be merged asap, I just did some changes on naming and stuff.
Btw, if I add
example_uploads, testing does not work because of not being able to import theExampleUploadsEntryPointclass. But it is not relevant for these changes.