Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copyright headers #137

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Update copyright headers #137

merged 1 commit into from
Jan 4, 2024

Conversation

domna
Copy link

@domna domna commented Jan 3, 2024

This updates the copyright headers to 2024 as generated by nyaml2nxdl

@domna domna changed the base branch from main to fairmat January 3, 2024 16:05
@domna domna requested a review from lukaspie January 3, 2024 16:06
@domna domna mentioned this pull request Jan 3, 2024
Copy link
Collaborator

@lukaspie lukaspie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Two things:

  1. Is there a good reason why only our recent changes to the contributed classes received the new year? IIRC, NIAC has a routine to set the new finishing date for all classes.
  2. We should make sure that we don't change the starting date for any of the existing classes (e.g. NXroot).

base_classes/NXroot.nxdl.xml Show resolved Hide resolved
@domna
Copy link
Author

domna commented Jan 4, 2024

Thanks for the update. Two things:

  1. Is there a good reason why only our recent changes to the contributed classes received the new year? IIRC, NIAC has a routine to set the new finishing date for all classes.

Actually, I don't completely know. I guess this depends on whether nyaml2nxdl uses the commented version when it was generated from nxdl vs. is completely generated from scratch.
I think we should have a discussion sometime on how to handle this, because I think there are some strange design decisions in how nyaml2nxdl handles this.

  1. We should make sure that we don't change the starting date for any of the existing classes (e.g. NXroot).

The starting dates are already changed in our repository for some files. I don't know the latest status of the copyright discussion. This PR just updates the current year as generated by nyaml2nxdl to fix ci/cd for the whole repo.

My suggestion: We merge this to fix nxdl <-> nyaml ci/cd and open an issue on the general topic for later discussion. Sounds good?

@lukaspie
Copy link
Collaborator

lukaspie commented Jan 4, 2024

Sounds good, you can merge this PR. I have created a new issues (#139) to keep track of the changed starting dates.

Copy link
Collaborator

@lukaspie lukaspie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@domna domna merged commit 04b69ac into fairmat Jan 4, 2024
4 checks passed
@domna domna deleted the update-copyright branch January 4, 2024 10:16
lukaspie pushed a commit that referenced this pull request Sep 24, 2024
# Conflicts:
#	base_classes/NXroot.nxdl.xml
#	contributed_definitions/NXchamber.nxdl.xml
#	contributed_definitions/NXem_conventions.nxdl.xml
#	contributed_definitions/NXidentifier.nxdl.xml
#	contributed_definitions/NXimage_set.nxdl.xml
#	contributed_definitions/NXinteraction_vol_em.nxdl.xml
#	contributed_definitions/NXpump.nxdl.xml
#	contributed_definitions/NXrotation_set.nxdl.xml
#	contributed_definitions/NXserialized.nxdl.xml
#	contributed_definitions/NXxrd.nxdl.xml
#	contributed_definitions/NXxrd_pan.nxdl.xml
lukaspie pushed a commit that referenced this pull request Sep 24, 2024
# Conflicts:
#	base_classes/NXroot.nxdl.xml
#	contributed_definitions/NXchamber.nxdl.xml
#	contributed_definitions/NXcomponent_em.nxdl.xml
#	contributed_definitions/NXem_adf.nxdl.xml
#	contributed_definitions/NXem_conventions.nxdl.xml
#	contributed_definitions/NXem_conventions_ebsd.nxdl.xml
#	contributed_definitions/NXidentifier.nxdl.xml
#	contributed_definitions/NXimage_r_set_diff.nxdl.xml
#	contributed_definitions/NXinteraction_vol_em.nxdl.xml
#	contributed_definitions/NXms_ipf.nxdl.xml
#	contributed_definitions/NXms_ipf_set.nxdl.xml
#	contributed_definitions/NXms_mtex_config.nxdl.xml
#	contributed_definitions/NXms_odf.nxdl.xml
#	contributed_definitions/NXms_odf_set.nxdl.xml
#	contributed_definitions/NXms_pf.nxdl.xml
#	contributed_definitions/NXms_pf_set.nxdl.xml
#	contributed_definitions/NXms_recon.nxdl.xml
#	contributed_definitions/NXpump.nxdl.xml
#	contributed_definitions/NXrotation_set.nxdl.xml
#	contributed_definitions/NXserialized.nxdl.xml
#	contributed_definitions/NXxrd.nxdl.xml
#	contributed_definitions/NXxrd_pan.nxdl.xml
lukaspie pushed a commit that referenced this pull request Dec 11, 2024
# Conflicts:
#	base_classes/NXroot.nxdl.xml
#	contributed_definitions/NXchamber.nxdl.xml
#	contributed_definitions/NXem_conventions.nxdl.xml
#	contributed_definitions/NXidentifier.nxdl.xml
#	contributed_definitions/NXimage_set.nxdl.xml
#	contributed_definitions/NXinteraction_vol_em.nxdl.xml
#	contributed_definitions/NXpump.nxdl.xml
#	contributed_definitions/NXrotation_set.nxdl.xml
#	contributed_definitions/NXserialized.nxdl.xml
#	contributed_definitions/NXxrd.nxdl.xml
#	contributed_definitions/NXxrd_pan.nxdl.xml
lukaspie pushed a commit that referenced this pull request Dec 11, 2024
# Conflicts:
#	base_classes/NXroot.nxdl.xml
#	contributed_definitions/NXchamber.nxdl.xml
#	contributed_definitions/NXcomponent_em.nxdl.xml
#	contributed_definitions/NXem_adf.nxdl.xml
#	contributed_definitions/NXem_conventions.nxdl.xml
#	contributed_definitions/NXem_conventions_ebsd.nxdl.xml
#	contributed_definitions/NXidentifier.nxdl.xml
#	contributed_definitions/NXimage_r_set_diff.nxdl.xml
#	contributed_definitions/NXinteraction_vol_em.nxdl.xml
#	contributed_definitions/NXms_ipf.nxdl.xml
#	contributed_definitions/NXms_ipf_set.nxdl.xml
#	contributed_definitions/NXms_mtex_config.nxdl.xml
#	contributed_definitions/NXms_odf.nxdl.xml
#	contributed_definitions/NXms_odf_set.nxdl.xml
#	contributed_definitions/NXms_pf.nxdl.xml
#	contributed_definitions/NXms_pf_set.nxdl.xml
#	contributed_definitions/NXms_recon.nxdl.xml
#	contributed_definitions/NXpump.nxdl.xml
#	contributed_definitions/NXrotation_set.nxdl.xml
#	contributed_definitions/NXserialized.nxdl.xml
#	contributed_definitions/NXxrd.nxdl.xml
#	contributed_definitions/NXxrd_pan.nxdl.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants