-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement base change directly in NXtransformations #235
base: fairmat
Are you sure you want to change the base?
Conversation
3c61c82
to
bd8a476
Compare
Feedback from today's PR:
|
For reference, also copying here from #249: The sense of "positive" rotation changes with the handedness of the CO system, i.e. one needs other rotation matrices depending on the handedness of the system. If you think about a rotation around the z-axis from the perspective of viewing from the origin towards the positive end of the z-axis, you have:
For any arbitrary rotation around axis
This is also what @domna implemented in the nexus3d package here. NXtransformations/@vector with |
bd8a476
to
d53cf0f
Compare
3defd6e
to
627a203
Compare
This is an add-on to #144 which essentially incorporates
NXcoordinate_system
directly withinNXtransformations
.There are three changes to
NXtransformations
:transformation_type
may bebase_change
, in which case a matrix containingn_dim
column vectors ofn_dim
length should be supplied.matrix
is added toAXISNAME
which shall containn_dim
column vectors ofn_dim
length. This is to be used to provide a matrix going from one coordinate system going to the other.direction
is added toAXISNAME
that provides a human-readable field which direction the axis points. This is to be used to a define a reference frame (i.e, for axes with no transformation_type). Ifmatrix
is filled, then this field shall contain the direction of alln-dim
matrix elements.Examples: