Skip to content

Commit

Permalink
fix haber reactant for results; remove description (changed in basese…
Browse files Browse the repository at this point in the history
…ction)
  • Loading branch information
schumannj committed Dec 19, 2024
1 parent f78478e commit 509cb0f
Showing 1 changed file with 1 addition and 19 deletions.
20 changes: 1 addition & 19 deletions src/nomad_catalysis/schema_packages/catalysis.py
Original file line number Diff line number Diff line change
Expand Up @@ -373,15 +373,6 @@ class CatalystSample(CompositeSystem, Schema):
links=['https://w3id.org/nfdi4cat/voc4cat_0000016'],
)

description = Quantity(
type=str,
shape=[],
description="""
A description of the catalyst sample.
""",
a_eln=dict(component='RichTextEditQuantity', props=dict(height=200)),
)

def populate_results(self, archive: 'EntryArchive', logger) -> None:
"""
This function copies the catalyst sample information specified in the dictionary
Expand Down Expand Up @@ -1269,15 +1260,6 @@ class CatalyticReactionCore(Measurement):
a_eln=dict(component='EnumEditQuantity'),
)

description = Quantity(
type=str,
shape=[],
description="""
A description of the catalyst sample.
""",
a_eln=dict(component='RichTextEditQuantity', props=dict(height=200)),
)


class CatalyticReactionData(PlotSection, MeasurementResult):
temperature = Quantity(
Expand Down Expand Up @@ -2306,7 +2288,7 @@ def reduce_haber_data(self, archive: 'EntryArchive', logger: 'BoundLogger') -> N
)
# archive.results.properties.catalytic.reaction.rate = [h2_rate]

react = Reactant(name='ammonia', conversion=Convs, fraction_in=NH3concs)
react = Reactant(name='ammonia', conversion=Convs, mole_fraction_in=NH3concs)

return react

Expand Down

0 comments on commit 509cb0f

Please sign in to comment.