Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample class #81

Closed
ka-sarthak opened this issue Sep 11, 2024 · 2 comments
Closed

Add sample class #81

ka-sarthak opened this issue Sep 11, 2024 · 2 comments
Assignees

Comments

@ka-sarthak
Copy link
Collaborator

The need for a Sample class emerges when multiple samples are cut from a bulk material, each treated as a separate entity. These samples have the same material system but can have different geometry and sample IDs assigned.

The Sample class should allow the reuse of a material system (a composite system itself) for multiple sample entries via reference.

Sample also inherits composite system, and reference to its material system is made in the components using a SystemComponent.

Sample(CompositeSystem):
  geometry = Geometry
  components = list[SystemComponent(reference=CompositeSystem)]
@ka-sarthak ka-sarthak self-assigned this Sep 11, 2024
@ka-sarthak ka-sarthak linked a pull request Sep 11, 2024 that will close this issue
@hampusnasstrom
Copy link
Collaborator

I think CompositeSystem is already the class you are looking for.

@ka-sarthak
Copy link
Collaborator Author

I summarized our discussions from today in the PR: #82 (comment)

@ka-sarthak ka-sarthak closed this as not planned Won't fix, can't repro, duplicate, stale Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants