Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample class #82

Closed
wants to merge 1 commit into from
Closed

Add sample class #82

wants to merge 1 commit into from

Conversation

ka-sarthak
Copy link
Collaborator

Resolves #81

@ka-sarthak ka-sarthak self-assigned this Sep 11, 2024
@ka-sarthak ka-sarthak linked an issue Sep 11, 2024 that may be closed by this pull request
Copy link
Collaborator

@hampusnasstrom hampusnasstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sample is a very loaded name and from very long discussions from before you came, I think we decided that sample is a role. This would be something we should definitely discuss with the whole A team before moving forward on.

@aalbino2
Copy link
Collaborator

I believe we can skip this intermediate class, let's simply add "geometry" subsection whereever is needed, like we have in substrate, without the need of this semi-general step

What do you think?

Copy link
Collaborator

@aalbino2 aalbino2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which is the sample that undergoes a cut and needs geometry specifications here?

@ka-sarthak
Copy link
Collaborator Author

@aalbino2 @hampusnasstrom I see. Based on our discussions in today's team meet:

  • getting a consensus on the term Sample will mean more discussions beyond this PR, which have already occurred in recent years.
  • CompositeSystem is meant to handle samples. A possibility could be to add geometry in the CompositeSystem. However, since geometry is optional for the composite system, it should be added while extending CompositeSystem.
  • In coming months, System will replace CompositeSystem, making these classes even more general. Adding geometry there is not recommended.
  • Suggestion: move this class to the IKZ plugin. And the name of the class will be <Synthesis process name>IKZSample.

@ka-sarthak ka-sarthak mentioned this pull request Sep 13, 2024
@ka-sarthak ka-sarthak closed this Sep 13, 2024
@ka-sarthak ka-sarthak deleted the 81-add-sample-class branch September 13, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sample class
3 participants