Update required nomad-lab version and add warning to README #86
Conversation
There was a problem hiding this comment.
Given that now we require index-url for the pip install, we can still keep using the dev versions, considering we know that 1.3.6 has some issues. And once a stable release (1.3.7) is available, we can directly bump to this one.
Also, there's a related PR: #79.
| @@ -28,7 +28,7 @@ authors = [ | |||
| ] | |||
| license = { file = "LICENSE" } | |||
| dependencies = [ | |||
| "nomad-lab>=1.3.4dev", | |||
| "nomad-lab>=1.3.6", | |||
There was a problem hiding this comment.
Given that now we require index-url for the pip install, we can still keep using the dev version (>=1.3.4dev)
There was a problem hiding this comment.
But 1.3.4.dev fails, no? We should require what is actually required to run the plugin or what do you mean?
There was a problem hiding this comment.
No, 1.3.4dev works because it pulls whatever latest dev (1.3.7devNN) is available on the registry
There was a problem hiding this comment.
For the issue that Fabian is facing, I think using the index-URL should solve it for him as you mentioned on the issue, as now when pip installing, the latest dev of nomad-lab will be pulled.
For the general milestone issue that we need a stable version as a dependency, we only have 1.3.6 as the current viable option (as 1.3.4 would fail the pytest). However, as you pointed out in today's discussion, there are some important issues not addressed in 1.3.6 and we should wait for a 1.3.7 #79 (comment)
There was a problem hiding this comment.
That is not how a dependency works @ka-sarthak. If I write numpy >= 1.3.4 in the toml it will pull the latest from PyPI which is 2.1.1 but by listing numpy >= 1.3.4 in the toml we are saying that it should work with anything above and including that version! If we put 1.3.4.dev in our toml and someone has 1.3.4.dev32 installed locally they will not get nomad-lab updated and the solution class will not work. Do you understand what I mean?
There was a problem hiding this comment.
I think you are right when it comes to pip updating the version of an already installed package. I always tested it with a fresh environment, so 1.3.4dev picked the latest dev, for example, 1.3.7.dev{something}, and never encountered the issue you pointed above. Let's use 1.3.6 then.
hampusnasstrom
deleted the
84-install-via-pip-fails-with-current-version
branch
Updated the required nomad-lab version to 1.3.6 and added a warning that users have to use the index url to the readme.