generated from FAIRmat-NFDI/nomad-plugin-template
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing parsing #3
Open
JosePizarro3
wants to merge
26
commits into
develop
Choose a base branch
from
fixing_parsing
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11271950375Details
💛 - Coveralls |
Clean up of methods
Deleted copyright comment at the beginning of the files Defined workflow_dft_files in Wannier90Parser
8 tasks
JosePizarro3
force-pushed
the
fixing_parsing
branch
4 times, most recently
from
September 27, 2024 10:16
0934e08
to
6b89753
Compare
JosePizarro3
force-pushed
the
fixing_parsing
branch
from
September 27, 2024 10:59
6b89753
to
258398a
Compare
JosePizarro3
force-pushed
the
fixing_parsing
branch
from
October 2, 2024 08:12
17b4f60
to
bf48a74
Compare
JosePizarro3
force-pushed
the
fixing_parsing
branch
3 times, most recently
from
October 10, 2024 10:04
d3b7a88
to
ced437d
Compare
JosePizarro3
force-pushed
the
fixing_parsing
branch
from
October 10, 2024 10:10
ced437d
to
b2f7909
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
reciprocal_lattice_vectors
--> this is normal as the normalization ofKMesh
andKLinePath
happens before than forKSpace
, so thatreciprocal_lattice_vectors
might not exist when being called in the sub-sections (KMesh and KLinePath) normalizers.entity_ref
and to set the name of the DOSProfile. I will improve this warning by adding a check for the name being'ElectronicDensityOfStates'
directlyoccupation
not defined invalidate_quantity_wrt_value
--> this is expected as in the Wannier90, the occupations of each bands are not properly defined (the FermiLevel.value needs to be resolved from the DFT entry).SinglePoint.inputs
andoutputs
sections are not properly referenced --> everything seems to be working in the backend...TODO:
KSpace
and then its subsections (KMesh
andKLinePath
).spectral_profile.py
adding condition forif self.name == 'ElectronicDensityOfStates'
for total DOS.ElectronicBandStructure.normalize()
once DFT+TB workflow is resolved.SinglePoint.inputs
andoutputs
section are not shown gitlab nomad #2164