Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing parsing #3

Open
wants to merge 26 commits into
base: develop
Choose a base branch
from
Open

Fixing parsing #3

wants to merge 26 commits into from

Conversation

JosePizarro3
Copy link
Collaborator

@JosePizarro3 JosePizarro3 commented Jul 24, 2024

Checklist:

  • Check warning with reciprocal_lattice_vectors --> this is normal as the normalization of KMesh and KLinePath happens before than for KSpace, so that reciprocal_lattice_vectors might not exist when being called in the sub-sections (KMesh and KLinePath) normalizers.
  • Check warning with entity_ref in DOSProfile --> this is happening because for total DOS there is a check for entity_ref and to set the name of the DOSProfile. I will improve this warning by adding a check for the name being 'ElectronicDensityOfStates' directly
  • Check occupation not defined in validate_quantity_wrt_value --> this is expected as in the Wannier90, the occupations of each bands are not properly defined (the FermiLevel.value needs to be resolved from the DFT entry).
  • Check why SinglePoint.inputs and outputs sections are not properly referenced --> everything seems to be working in the backend...

TODO:

  • Talk with @ladinesa about changing order of normalization for 1st KSpace and then its subsections (KMesh and KLinePath).
  • Fix warning in spectral_profile.py adding condition for if self.name == 'ElectronicDensityOfStates' for total DOS.
  • Overwrite FermiLevel and call for ElectronicBandStructure.normalize() once DFT+TB workflow is resolved.
  • No idea why, but in the frontend, the SinglePoint.inputs and outputs section are not shown gitlab nomad #2164

@coveralls
Copy link

coveralls commented Jul 25, 2024

Pull Request Test Coverage Report for Build 11271950375

Details

  • 103 of 138 (74.64%) changed or added relevant lines in 7 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.8%) to 80.435%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/nomad_parser_wannier90/parsers/init.py 5 7 71.43%
src/nomad_parser_wannier90/parsers/win_parser.py 42 48 87.5%
src/nomad_parser_wannier90/parsers/utils/utils.py 5 13 38.46%
src/nomad_parser_wannier90/parsers/parser.py 48 67 71.64%
Files with Coverage Reduction New Missed Lines %
src/nomad_parser_wannier90/parsers/parser.py 1 86.05%
src/nomad_parser_wannier90/schema_packages/package.py 3 0.0%
Totals Coverage Status
Change from base Build 9952693436: 0.8%
Covered Lines: 407
Relevant Lines: 506

💛 - Coveralls

@JosePizarro3 JosePizarro3 force-pushed the fixing_parsing branch 4 times, most recently from 0934e08 to 6b89753 Compare September 27, 2024 10:16
@JosePizarro3 JosePizarro3 force-pushed the fixing_parsing branch 3 times, most recently from d3b7a88 to ced437d Compare October 10, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants