Xrd reader integration

[RubelMozumder]

PR:

1. XRD Reader for xrdml file.
2. Refactoring some functions into multiple functions so that the features of the original function can be used separately.
3. Update test_mpes_writting according to the modified application definition that come from nexus def. PR-51.
4. Updating test file for nexus test test_get_node_at_nxdl_path() according to PR-51 (see above). Now that the test file has been placed in the test data folder, the nexus feature test does not break due to change in application modification.

Next Step:

1. To make the reader generalised for other version of the xrdml files.
2. To include other types of file e.g. udf, xye, etc, and the several version of that file.

[RubelMozumder]

@sherjeelshabih, @lukaspie or @domna can you review the PR. I need to merge it in a bit hurry, so that I bring this into the nomad develop branch and finish the first step of XRD project.

[lukaspie]

Thanks @RubelMozumder, it look already quite nice. Some comments:

• The XRD works once you implement the change I am suggesting in the xrd_helper.
• Files and test notebooks should be removed.

I am now checking if the updates to the converter/writer also work for other data than XRD.

[lukaspie]

LGTM

[coveralls]

Pull Request Test Coverage Report for Build 7075918067

• 352 of 412 (85.44%) changed or added relevant lines in 10 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage increased (+1.1%) to 52.122%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pynxtools/nexus/nexus.py	11	12	91.67%
pynxtools/dataconverter/convert.py	25	27	92.59%
pynxtools/dataconverter/readers/xrd/xrd_helper.py	88	96	91.67%
pynxtools/dataconverter/helpers.py	33	42	78.57%
pynxtools/dataconverter/readers/xrd/xrd_parser.py	126	137	91.97%
pynxtools/dataconverter/readers/xrd/reader.py	41	70	58.57%

Files with Coverage Reduction	New Missed Lines	%
pynxtools/dataconverter/convert.py	1	81.25%

Totals
Change from base Build 7045854627:	1.1%
Covered Lines:	6152
Relevant Lines:	11803

---

💛 - Coveralls

[sanbrock]

LGTM

[sanbrock]

The update of nexus_definitions does not seem to be correct and matching the MPES and EM tests.

[RubelMozumder]

The update of nexus_definitions does not seem to be correct and matching the MPES and EM tests.

This EM application definition is changed in fairmat brach.

Not responsive.

[RubelMozumder]

Sorry @sherjeelshabih for turning off you from PR. I thought I could immediately merge the PR after tuning off you from the reviewer list. But later I see another blocker from Markus PR in Nexus definition.

[sherjeelshabih]

Sorry @sherjeelshabih for turning off you from PR. I thought I could immediately merge the PR after tuning off you from the reviewer list. But later I see another blocker from Markus PR in Nexus definition.

No worries. Just relax.
I've solved the duplicate code issue I was asking for in another PR, #190.
I'll add you as a reviewer there.