Nexus file parsing refactoring #303
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanbrock
reviewed
Apr 2, 2024
| nx_name=get_nxdl_entry(hdf_info), | ||
| hdf_node=hdf_node, | ||
| hdf_path=hdf_info["hdf_path"] if "hdf_path" in hdf_info else None, | ||
| hdf_root=hdf_info["hdf_root"] if "hdf_root" in hdf_info else None, | ||
| ) | ||
| # Copy the nxdl_path, otherwise the cached object is altered | ||
| nxdl_path = nxdl_path.copy() |
There was a problem hiding this comment.
also covert by another PR
sanbrock
reviewed
Apr 2, 2024
| self.input_file_name = ( | ||
| nexus_file | ||
| if nexus_file is not None | ||
| else os.path.join(local_dir, "../../tests/data/nexus/201805_WSe2_arpes.nxs") |
There was a problem hiding this comment.
default option is to run it as an example on the provided test file
sanbrock
reviewed
Apr 2, 2024
|
|
||
| def visit_node(self, hdf_name, hdf_node): | ||
| """Function called by h5py that iterates on each node of hdf5file. | ||
| It allows h5py visititems function to visit nodes.""" | ||
| if self.d_inq_nd is None and self.c_inq_nd is None: | ||
| process_node(hdf_node, "/" + hdf_name, self.parser, self.logger) |
There was a problem hiding this comment.
default option is to annotate the whole file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A general note on the code: It is really hard to understand what is happening in this code part and I'm not sure whether there are other problems because it's hard to get a general overview. I have a few recommendations on general refactoring: