-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow for checking against NOMAD dependencies #345
Conversation
Pull Request Test Coverage Report for Build 9403361773Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9403375758Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9403398882Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9403534362Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9403561424Details
💛 - Coveralls |
It might make sense to use uv instead of |
26a7ba9
to
85c79a3
Compare
Pull Request Test Coverage Report for Build 9431429305Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9431439243Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9431477569Details
💛 - Coveralls |
bd7886c
to
ce1588d
Compare
Pull Request Test Coverage Report for Build 9431489665Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 9431489665Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9431500922Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9431554831Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9431605383Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9431721135Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I left a few comments for cleanup
Pull Request Test Coverage Report for Build 9473182354Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
3 similar comments
Pull Request Test Coverage Report for Build 9473182354Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9473182354Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9473182354Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9473193332Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9473276074Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
2 similar comments
Pull Request Test Coverage Report for Build 9473276074Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9473276074Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This is a draft for how we can make sure that the dependencies in the pyproject.toml file are in line with the NOMAD dependencies.
Strategy:
- [x] pip-compile pyproject.toml to a requirements file- checkout NOMAD requirements from GitLab- Combine the two requirements file and try to install the combined fileEDIT:
uv pip compile
to generate the requirements-(dev).txtPossible improvements:
Fixes #85