Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow for checking against NOMAD dependencies #345

Merged
merged 15 commits into from
Jun 11, 2024

Conversation

lukaspie
Copy link
Collaborator

@lukaspie lukaspie commented Jun 6, 2024

This is a draft for how we can make sure that the dependencies in the pyproject.toml file are in line with the NOMAD dependencies.

Strategy:
- [x] pip-compile pyproject.toml to a requirements file
- checkout NOMAD requirements from GitLab
- Combine the two requirements file and try to install the combined file
EDIT:

  • check out NOMAD@develop and init all its submodules
  • in nomad/pyproject.toml, replace the pynxtools[convert]== by pynxtools[convert]@git+https://github.com/FAIRmat-NFDI/pynxtools.git@ to check if the current branch makes any problematic changes
  • use NOMADS uv pip compile to generate the requirements-(dev).txt
  • try to install these

Possible improvements:

  • only run this workflow if the pyproject.toml has actually changed
  • return possibly resolving dependencies

Fixes #85

@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9403361773

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.08%) to 78.406%

Files with Coverage Reduction New Missed Lines %
tests/dataconverter/test_writer.py 1 96.67%
pynxtools/dataconverter/validation.py 1 67.82%
pynxtools/dataconverter/helpers.py 1 79.21%
Totals Coverage Status
Change from base Build 9399580646: -0.08%
Covered Lines: 2814
Relevant Lines: 3589

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9403375758

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 78.49%

Files with Coverage Reduction New Missed Lines %
pynxtools/dataconverter/validation.py 1 68.2%
Totals Coverage Status
Change from base Build 9399580646: 0.0%
Covered Lines: 2817
Relevant Lines: 3589

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9403398882

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 4 files lost coverage.
  • Overall coverage remained the same at 78.49%

Files with Coverage Reduction New Missed Lines %
tests/dataconverter/test_writer.py 1 96.67%
pynxtools/dataconverter/validation.py 1 67.82%
pynxtools/dataconverter/helpers.py 1 79.21%
pynxtools/dataconverter/convert.py 2 74.71%
Totals Coverage Status
Change from base Build 9399580646: 0.0%
Covered Lines: 2817
Relevant Lines: 3589

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9403534362

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage remained the same at 78.49%

Files with Coverage Reduction New Missed Lines %
tests/dataconverter/test_writer.py 1 96.67%
pynxtools/dataconverter/validation.py 1 68.2%
pynxtools/dataconverter/helpers.py 1 79.21%
Totals Coverage Status
Change from base Build 9399580646: 0.0%
Covered Lines: 2817
Relevant Lines: 3589

💛 - Coveralls

@lukaspie lukaspie linked an issue Jun 6, 2024 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9403561424

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 78.462%

Files with Coverage Reduction New Missed Lines %
tests/dataconverter/test_writer.py 1 96.67%
Totals Coverage Status
Change from base Build 9399580646: -0.03%
Covered Lines: 2816
Relevant Lines: 3589

💛 - Coveralls

@lukaspie lukaspie requested a review from domna June 6, 2024 15:27
@domna
Copy link
Collaborator

domna commented Jun 6, 2024

It might make sense to use uv instead of pip-compile. I think nomad is switching to it and it is way faster. This might benefit this ci/cd as well.

@lukaspie
Copy link
Collaborator Author

lukaspie commented Jun 8, 2024

It might make sense to use uv instead of pip-compile. I think nomad is switching to it and it is way faster. This might benefit this ci/cd as well.

I have a PR (#347) to use uv across the whole repository for compiling and installing requirements.

@lukaspie lukaspie force-pushed the check-nomad-requirements branch from 26a7ba9 to 85c79a3 Compare June 8, 2024 20:43
@coveralls
Copy link

coveralls commented Jun 8, 2024

Pull Request Test Coverage Report for Build 9431429305

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.603%

Totals Coverage Status
Change from base Build 9416111276: 0.0%
Covered Lines: 570
Relevant Lines: 584

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 8, 2024

Pull Request Test Coverage Report for Build 9431439243

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.603%

Totals Coverage Status
Change from base Build 9416111276: 0.0%
Covered Lines: 570
Relevant Lines: 584

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 8, 2024

Pull Request Test Coverage Report for Build 9431477569

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.603%

Totals Coverage Status
Change from base Build 9416111276: 0.0%
Covered Lines: 570
Relevant Lines: 584

💛 - Coveralls

@lukaspie lukaspie force-pushed the check-nomad-requirements branch from bd7886c to ce1588d Compare June 8, 2024 20:57
@coveralls
Copy link

coveralls commented Jun 8, 2024

Pull Request Test Coverage Report for Build 9431489665

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.603%

Totals Coverage Status
Change from base Build 9416111276: 0.0%
Covered Lines: 570
Relevant Lines: 584

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9431489665

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.603%

Totals Coverage Status
Change from base Build 9416111276: 0.0%
Covered Lines: 570
Relevant Lines: 584

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 8, 2024

Pull Request Test Coverage Report for Build 9431500922

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.603%

Totals Coverage Status
Change from base Build 9416111276: 0.0%
Covered Lines: 570
Relevant Lines: 584

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 8, 2024

Pull Request Test Coverage Report for Build 9431554831

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.603%

Totals Coverage Status
Change from base Build 9416111276: 0.0%
Covered Lines: 570
Relevant Lines: 584

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 8, 2024

Pull Request Test Coverage Report for Build 9431605383

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.603%

Totals Coverage Status
Change from base Build 9416111276: 0.0%
Covered Lines: 570
Relevant Lines: 584

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 8, 2024

Pull Request Test Coverage Report for Build 9431721135

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.603%

Totals Coverage Status
Change from base Build 9416111276: 0.0%
Covered Lines: 570
Relevant Lines: 584

💛 - Coveralls

Copy link
Collaborator

@domna domna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I left a few comments for cleanup

.github/workflows/nomad-requirements.yml Outdated Show resolved Hide resolved
.github/workflows/nomad-requirements.yml Outdated Show resolved Hide resolved
.github/workflows/nomad-requirements.yml Show resolved Hide resolved
.github/workflows/nomad-requirements.yml Outdated Show resolved Hide resolved
Copy link
Contributor

Pull Request Test Coverage Report for Build 9473182354

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.603%

Totals Coverage Status
Change from base Build 9416111276: 0.0%
Covered Lines: 570
Relevant Lines: 584

💛 - Coveralls

3 similar comments
Copy link
Contributor

Pull Request Test Coverage Report for Build 9473182354

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.603%

Totals Coverage Status
Change from base Build 9416111276: 0.0%
Covered Lines: 570
Relevant Lines: 584

💛 - Coveralls

Copy link
Contributor

Pull Request Test Coverage Report for Build 9473182354

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.603%

Totals Coverage Status
Change from base Build 9416111276: 0.0%
Covered Lines: 570
Relevant Lines: 584

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 11, 2024

Pull Request Test Coverage Report for Build 9473182354

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.603%

Totals Coverage Status
Change from base Build 9416111276: 0.0%
Covered Lines: 570
Relevant Lines: 584

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 11, 2024

Pull Request Test Coverage Report for Build 9473193332

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 97.432%

Totals Coverage Status
Change from base Build 9416111276: -0.2%
Covered Lines: 569
Relevant Lines: 584

💛 - Coveralls

@lukaspie lukaspie marked this pull request as ready for review June 11, 2024 21:55
@coveralls
Copy link

coveralls commented Jun 11, 2024

Pull Request Test Coverage Report for Build 9473276074

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 97.432%

Totals Coverage Status
Change from base Build 9416111276: -0.2%
Covered Lines: 569
Relevant Lines: 584

💛 - Coveralls

2 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9473276074

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 97.432%

Totals Coverage Status
Change from base Build 9416111276: -0.2%
Covered Lines: 569
Relevant Lines: 584

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9473276074

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 97.432%

Totals Coverage Status
Change from base Build 9416111276: -0.2%
Covered Lines: 569
Relevant Lines: 584

💛 - Coveralls

@lukaspie lukaspie merged commit 57d6934 into master Jun 11, 2024
10 checks passed
@lukaspie lukaspie deleted the check-nomad-requirements branch June 11, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check against nomad dependencies
3 participants