-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nexus validation tutorial #402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, a nice start and quite helpful for the upcoming workshops.
- I don't see why all the nexus files should be added here, upload them to Zenodo/NOMAD and add a download link if needed.
- Split the hardcode nxs file creation from the validation.
- Note that these are the pynxtools docs. Therefore, whenever there is a departure from the envisioned workflow (i.e., pynx-plugin + internal validation vs. hardcoding + external validation), there should be some explanatory text a) why this is useful, and b) that we still recommend people to use pynxtools (and why that is, i.e. automatic tooling + validation).
- In some places, there are links that could be abbreviated using text. You can build the docs locally using
mkdocs serve
and check that the links look nice. - You need to modify the
mkdocs.yaml
file as well so that the new docs are actually showing up after the build.
Sorry I was a bit critical in some places. Just suggestions so that people can use the docs more easily :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that none of them is working properly.
In this context I suggest to add the relevant verification tools to the nexus north container (I think some are already installed). Then they can be very easily used on Windows. |
@RonHildebrandt FYI, in #412, I have suggested a new structure for our docs. We then have a page https://fairmat-nfdi.github.io/pynxtools/learn/nexus-verification.html. I think there we could ideally place your verification notes. I intentionally structured it so that we can describe our tools (verification when using pynxtools chain, verify-nexus, read-nexus) first (because we want people to use them), but then also describe other approches like cnxvalidate. What do you think? |
Hey, thanks @lukaspie @mkuehbach @RubelMozumder for all the feedback and help with improvements. Some ideas I was just simply not aware of (links). The splitting was done as adviced. Many typo changes and use clearer/better terms were included. I hope this suits now better. I found 3 other links from How-Tos on the website to be almost "empty". I removed them, as this just looks unprofessional ob the website. I left a note that this is in progress. Not sure if this transforms to the PR412, as I just head from this. |
… it just diffcult to install
…internal development notes
…lidate, add testing validation
… dataconverter required a config file if it was called the classical way and in case no parameter yaml file was provided. For programmatically use of the converter the creation of an additional params file with only a few entries is unnecessary overhead especially when all cli arguments are available in the callers scope and thus the CLI call can be issues directly using the classical way dataconverter convert [INPUTFILES] options
f2e7cc1
to
4203a4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly typo fixes and structural changes
Co-authored-by: Lukas Pielsticker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -11,12 +11,11 @@ nav: | |||
- tutorial/converting-data-to-nexus.md | |||
- tutorial/nexus-to-nomad.md | |||
- How-tos: | |||
- how-tos/writing-an-appdef.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these should not be removed (even if they are not yet fully fleshed out), I readded them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can leave them in the tree on the left-hand side and say in index.md that they are under development
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I put intially somewhere a note that this is deveopled, but not yet ready. If it should be this way, Im fine with that. Just doesn't look profesionally if someone visits this site and sees that 3 guides are construction sites (not sure for how this state is).
anyway, then lets keep it.
This tutorial is supposed to be a very low entry level for the creation of NeXus files by hardcoding via python. This is therefore not limited to specific experimental techniques. I use NXoptical_spectroscopy as example.The second part is, to use show which methods are right now present, to validate the created files (nxvalidate, punx, pynxtools).
I also added a second .md file, with my experience for validation methods, which are of relevance for development. There are also notes for the installation of cnxvalidate.
Short summary:
_____ TODOs ___________