using readonly instead of user_editability; enabling injesting multip… #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le methods to the base classes and not only the normalization; Entry to inherit also from Task, so Workflow click drives there directly
…sation from Measurement and Activity
lukaspie
requested changes
Dec 19, 2024
There was a problem hiding this comment.
We should definitely also think how we can keep this clean and maintainable in the future. Maybe we can separate the actual schema creation a bit from the definition of new base section classes and normalization functions (i.e, move these to a new python file in the future)
| @@ -105,8 +106,8 @@ | |||
| "NXsample": [CompositeSystem], | |||
| "NXsample_component": [Component], | |||
| "NXidentifier": [EntityReference], | |||
| "NXentry": [ActivityStep], | |||
| "NXprocess": [ActivityStep], | |||
| "NXentry": [ActivityStep], # , Task], | |||
There was a problem hiding this comment.
remove comment here if not used
| ) | ||
| # one could also copy local ids to identifier for search purposes | ||
| super(current_cls, self).normalize(archive, logger) | ||
|
|
||
|
|
||
| # def to_task_itself(self): |
Comment on lines
+145
to
+150
| if archive.results.eln.methods is None: | ||
| archive.results.eln.methods = [] | ||
| if self.method: | ||
| archive.results.eln.methods.append(self.method) | ||
| else: | ||
| archive.results.eln.methods.append(self.m_def.name) |
There was a problem hiding this comment.
Do we actually want to fill the results.eln.methods section? Is that needed in any way? If not, I suggest we remove it here.
| @@ -105,8 +106,8 @@ | |||
| "NXsample": [CompositeSystem], | |||
| "NXsample_component": [Component], | |||
| "NXidentifier": [EntityReference], | |||
| "NXentry": [ActivityStep], | |||
| "NXprocess": [ActivityStep], | |||
| "NXentry": [ActivityStep], # , Task], | |||
There was a problem hiding this comment.
This should eventually becomes its own workflow (nested in the workflow of the whole nxs file) containing its own Tasks. But fine for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…le methods to the base classes and not only the normalization; Entry to inherit also from Task, so Workflow click drives there directly