Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace nomad plugin logo #512

Merged
merged 5 commits into from
Jan 17, 2025
Merged

Conversation

lukaspie
Copy link
Collaborator

@lukaspie lukaspie commented Jan 10, 2025

@mkuehbach the new docs would look like this, is this what you wanted? Clicking on that icon also just brings you back to the home page of the docs now.
image

I also added a navigation in the footer and changed the favicon to the nomad plugins logo.

@lukaspie lukaspie requested a review from mkuehbach January 10, 2025 18:31
@lukaspie lukaspie linked an issue Jan 10, 2025 that may be closed by this pull request
@lukaspie lukaspie force-pushed the 511-use-new-fairmat-nomad-plugin-logo branch from 0f7b54a to 01cff25 Compare January 11, 2025 13:34
Copy link
Collaborator

@mkuehbach mkuehbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically the changes look good to me.
I was not aware though that such new logo at all exists, we should maybe ask the management if we ought
are allowed to use that logo for pynxtools (and all of its FAIRmat-maintained pynxtools-plugins),

i.e. what is the usage policy when software tools are official NOMAD plugins to qualify for such logo?

If we get the green light from the management, sure merge this in. Thank you.

@lukaspie
Copy link
Collaborator Author

i.e. what is the usage policy when software tools are official NOMAD plugins to qualify for such logo?

These are the logos that are used by all of the NOMAD plugins that are generated from the template (see here), so I think it's safe to say we can use them.

@lukaspie lukaspie force-pushed the 511-use-new-fairmat-nomad-plugin-logo branch from a604648 to 397add9 Compare January 17, 2025 13:52
@lukaspie lukaspie force-pushed the 511-use-new-fairmat-nomad-plugin-logo branch from 397add9 to f58dcc6 Compare January 17, 2025 13:53
Copy link
Collaborator

@sanbrock sanbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukaspie lukaspie merged commit 9ca60a3 into master Jan 17, 2025
17 checks passed
@lukaspie lukaspie deleted the 511-use-new-fairmat-nomad-plugin-logo branch January 17, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use new FAIRmat NOMAD Plugin corporate design for all pynxtools
3 participants