-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lecture to summer semester 2023 #68
Conversation
…ent to Quinlan's original dataset, see also PR #55
@dominik-probst: Feel free to include any updates that you have from your side to this PR, or - alternatively - create a separate PR. |
…tes, preliminary schedule, updated StudOn links
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I have one small comment, which I consider so insignificant that you may decide whether to merge directly or to adjust it.
Since I still need a few days for my adjustments (and will also spread them over several weeks until the semester starts) it is probably better to start a separate PR for my adjustments. |
… started the big rework of exercise-3 to add pictures and step-by-step explantions for aprioir and fpgrowth later on in the process
…scussed in MS Teams
…the StudOn course was not yet updated
…due to an out of date Jupyter version)
…due to an out of date Jupyter version)
…hat occured due to the new example
…uded a task numbering for easier communication with the students during the exercise sessions
…e new layout to the tasksheet + some small fixes in other exercise sheets
…d finetuned the rest of the K-Means section
… with the new dataset
…d implement a hands-on-task regarding DBSCAN
…to make it more rounded
… the CI/CD process
… lecture and moved the Monday exercise to Friday. As the previous merge lead to problems with the pre-commit hooks I also run pre-commit on all files
…t exercise sheet to the exercise and formatted the exercise sheet(s) to be easier accessible
…her style changes previously introduced to the other exercises) to this exercise, too
Since my planned SS23 changes have been finished since yesterday, I have taken the liberty of attaching them to this PR. These changes are primarily:
In the course of today I have also added the following changes to this PR:
Since I already reviewed your changes (including yesterday's schedule change) and found them to be good, I would now ask you to review my changes @melsigl . Since I made the introduction of the table of contents and the task numbering in your two exercises without consultation with you, I have also indicated the commit here in each case, so that you can easily undo these changes, should they not have been in your interest. |
…the new naming scheme of the exercises
Thank you, @dominik-probst, for your effort to update our lecture slides and our exercises. Your changes sound valid to me even though I had not the luxury to invest the time it deserves to read every change in all its detail. However, I have some (minor) notes: Exercises:
Lectures:
I also had to add a fix to the classification exercise involving Naive Bayes. All in all, consider my consent to approve & merge as I cannot change the reviewer to myself and merge without bypassing our branch protection. |
Changes so far include, but may not limit to:
See also potential comments under this PR.