Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 카트 주소 미변경 이슈 해결 #126

Merged
merged 3 commits into from
Oct 12, 2024

Conversation

sionyeom
Copy link
Contributor

@sionyeom sionyeom requested a review from kichul7493 October 12, 2024 01:40
@sionyeom sionyeom self-assigned this Oct 12, 2024
Copy link
Contributor

@kichul7493 kichul7493 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코멘트 확인 부탁 드립니다.

수정이 필요해보입니다.

@@ -46,6 +48,7 @@ const AddressListItem = ({ ...props }: AddressData) => {
queryKey: ['storeList', '', null],
})
updateMainAddress(props.addressId)
router.push('/cart')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주소 관리 페이지는 메인화면의 주소 변경, 마이 페이지의 주소 관리에서도 사용되는데,

router.push('/cart') 로 인해 어느 페이지에서 주소를 변경해도 카트 페이지로 이동되는 이슈가 발생하네요.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아앗 그렇군요..! 수정하겠습니다

@sionyeom sionyeom requested a review from kichul7493 October 12, 2024 02:09
@sionyeom sionyeom merged commit 3d54670 into dev Oct 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants