Feature/#117 refactoring #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kichul7493
requested review from
sionyeom,
jun0811 and
ljh981009
and removed request for
sionyeom and
jun0811
sionyeom
approved these changes
Oct 15, 2024
jun0811
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#117
코드 리팩터링을 진행했습니다.
진행한 항목은 이슈로 확인 부탁 드리겠습니다. 중복 컴포넌트 제거는 거의 진행을 못했네요.
수정하고 싶은 부분이 있으시면 언제든지 브랜치에서 수정 해서 올려주시면 감사하겠습니다.
readme 파일에 추가하고 싶은 내용 있으시면 추가해주세요~
수정 사항이 많아서 리뷰는 커밋 단위로 하시는 걸 추천드립니다.
전체적인 수정이라 3분 모두에게 리뷰 요청 드립니다.